Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: runtime/vm/simulator_mips.cc

Issue 1644793002: Replace intptr_t with TokenDescriptor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/simulator_mips.cc
diff --git a/runtime/vm/simulator_mips.cc b/runtime/vm/simulator_mips.cc
index f8007edac85e76716fbc1527e34c168b907030ba..d7cdc1555adf663508e596ff3c378df3535d0c27 100644
--- a/runtime/vm/simulator_mips.cc
+++ b/runtime/vm/simulator_mips.cc
@@ -94,11 +94,11 @@ class SimulatorDebugger {
bool GetFValue(char* desc, double* value);
bool GetDValue(char* desc, double* value);
- static intptr_t GetApproximateTokenIndex(const Code& code, uword pc);
+ static TokenDescriptor GetApproximateTokenIndex(const Code& code, uword pc);
static void PrintDartFrame(uword pc, uword fp, uword sp,
const Function& function,
- intptr_t token_pos,
+ TokenDescriptor token_pos,
bool is_optimized,
bool is_inlined);
void PrintBacktrace();
@@ -256,9 +256,9 @@ bool SimulatorDebugger::GetDValue(char* desc, double* value) {
}
-intptr_t SimulatorDebugger::GetApproximateTokenIndex(const Code& code,
+TokenDescriptor SimulatorDebugger::GetApproximateTokenIndex(const Code& code,
uword pc) {
- intptr_t token_pos = -1;
+ TokenDescriptor token_pos = TokenDescriptor::kNoSource;
uword pc_offset = pc - code.EntryPoint();
const PcDescriptors& descriptors =
PcDescriptors::Handle(code.pc_descriptors());
@@ -266,7 +266,7 @@ intptr_t SimulatorDebugger::GetApproximateTokenIndex(const Code& code,
while (iter.MoveNext()) {
if (iter.PcOffset() == pc_offset) {
return iter.TokenPos();
- } else if ((token_pos <= 0) && (iter.PcOffset() > pc_offset)) {
+ } else if (!token_pos.IsReal() && (iter.PcOffset() > pc_offset)) {
token_pos = iter.TokenPos();
}
}
@@ -276,7 +276,7 @@ intptr_t SimulatorDebugger::GetApproximateTokenIndex(const Code& code,
void SimulatorDebugger::PrintDartFrame(uword pc, uword fp, uword sp,
const Function& function,
- intptr_t token_pos,
+ TokenDescriptor token_pos,
bool is_optimized,
bool is_inlined) {
const Script& script = Script::Handle(function.script());
@@ -284,7 +284,7 @@ void SimulatorDebugger::PrintDartFrame(uword pc, uword fp, uword sp,
const String& url = String::Handle(script.url());
intptr_t line = -1;
intptr_t column = -1;
- if (token_pos >= 0) {
+ if (token_pos.IsReal()) {
script.GetTokenLocation(token_pos, &line, &column);
}
OS::Print("pc=0x%" Px " fp=0x%" Px " sp=0x%" Px " %s%s (%s:%" Pd

Powered by Google App Engine
This is Rietveld 408576698