Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: tools/perf/perf_tools/smoothness_measurement.py

Issue 16438003: Android / Telemetry: make surface_stats_collector more robust. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: is None Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/surface_stats.py ('K') | « build/android/surface_stats.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/perf_tools/smoothness_measurement.py
diff --git a/tools/perf/perf_tools/smoothness_measurement.py b/tools/perf/perf_tools/smoothness_measurement.py
index d56219f1da7570abd6b9604a6c8c0326d3f17634..042d4b60a86bd41056a7a84d907066d1052794ac 100644
--- a/tools/perf/perf_tools/smoothness_measurement.py
+++ b/tools/perf/perf_tools/smoothness_measurement.py
@@ -9,6 +9,11 @@ class DidNotScrollException(page_measurement.MeasurementFailure):
def __init__(self):
super(DidNotScrollException, self).__init__('Page did not scroll')
+class MissingDisplayFrameRate(page_measurement.MeasurementFailure):
+ def __init__(self):
+ super(MissingDisplayFrameRate, self).__init__(
+ 'Missing display frame rate metrics')
+
def DivideIfPossibleOrZero(numerator, denominator):
if denominator == 0:
return 0
@@ -216,4 +221,6 @@ class SmoothnessMeasurement(page_measurement.PageMeasurement):
if tab.browser.platform.IsRawDisplayFrameRateSupported():
for r in tab.browser.platform.GetRawDisplayFrameRateMeasurements():
+ if not r.value:
+ raise MissingDisplayFrameRate()
results.Add(r.name, r.unit, r.value)
« build/android/surface_stats.py ('K') | « build/android/surface_stats.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698