Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/surface_stats.py

Issue 16438003: Android / Telemetry: make surface_stats_collector more robust. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: is None Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/surface_stats_collector.py ('k') | tools/perf/perf_tools/smoothness_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/surface_stats.py
diff --git a/build/android/surface_stats.py b/build/android/surface_stats.py
index 9cff25c04cc761ef8590a98b3f1e6a2e93253a20..1bce6ef4ac424deee4ca947fc6953e48efefe6c4 100755
--- a/build/android/surface_stats.py
+++ b/build/android/surface_stats.py
@@ -29,7 +29,8 @@ _FIELD_FORMAT = {
def _MergeResults(results, fields):
merged_results = collections.defaultdict(list)
for result in results:
- if fields != ['all'] and not result.name in fields:
+ if ((fields != ['all'] and not result.name in fields) or
+ result.value is None):
marja 2013/06/06 13:03:32 -> "or not result.value"
Sami 2013/06/06 13:10:03 See above; 0 is a valid result.value but None isn'
marja 2013/06/06 13:31:44 Ah, alright :)
continue
name = '%s (%s)' % (result.name, result.unit)
if isinstance(result.value, list):
« no previous file with comments | « build/android/pylib/surface_stats_collector.py ('k') | tools/perf/perf_tools/smoothness_measurement.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698