Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 16437002: Add check on Cube Completeness for Cube textures and improve the efficiency of checks associated wi… (Closed)

Created:
7 years, 6 months ago by Jun Jiang
Modified:
7 years, 6 months ago
CC:
blink-reviews, Rik, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add check on Cube Completeness for Cube textures and improve the efficiency of checks associated with OES_texture_{half_}float_linear extension. BUG=246815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152167

Patch Set 1 #

Total comments: 5

Patch Set 2 : Change code to make it more clear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M Source/core/html/canvas/WebGLTexture.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLTexture.cpp View 1 5 chunks +13 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Jun Jiang
According to OpenGL ES Spec 2.0.25 section 3.8.2, calling a sampler from a fragment shader ...
7 years, 6 months ago (2013-06-05 13:27:24 UTC) #1
bajones
I'm not an owner, but LGTM with one question. https://codereview.chromium.org/16437002/diff/1/Source/core/html/canvas/WebGLTexture.cpp File Source/core/html/canvas/WebGLTexture.cpp (right): https://codereview.chromium.org/16437002/diff/1/Source/core/html/canvas/WebGLTexture.cpp#newcode355 Source/core/html/canvas/WebGLTexture.cpp:355: ...
7 years, 6 months ago (2013-06-05 17:28:59 UTC) #2
Jun Jiang
Hi, bajones. Thanks for your comments. Following is my understanding on this. https://codereview.chromium.org/16437002/diff/1/Source/core/html/canvas/WebGLTexture.cpp File Source/core/html/canvas/WebGLTexture.cpp ...
7 years, 6 months ago (2013-06-06 01:19:48 UTC) #3
Ken Russell (switch to Gerrit)
Thanks for fixing this. LGTM with one additional fix. It looks like the WebGL test ...
7 years, 6 months ago (2013-06-06 23:16:43 UTC) #4
Jun Jiang
Hi, Kenneth. Thanks for your comments. For the case that width is not equal to ...
7 years, 6 months ago (2013-06-07 13:58:22 UTC) #5
Ken Russell (switch to Gerrit)
Thanks for pointing out that the TexImage2D call will actually be rejected for cube map ...
7 years, 6 months ago (2013-06-10 19:54:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jun.a.jiang@intel.com/16437002/28001
7 years, 6 months ago (2013-06-10 19:54:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=9440
7 years, 6 months ago (2013-06-10 23:24:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jun.a.jiang@intel.com/16437002/28001
7 years, 6 months ago (2013-06-10 23:38:41 UTC) #9
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 00:23:56 UTC) #10
Message was sent while issue was closed.
Change committed as 152167

Powered by Google App Engine
This is Rietveld 408576698