Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 16434016: Rewrite scoped_ptr<T>(NULL) to use the default ctor in net/. (Closed)

Created:
7 years, 6 months ago by dcheng
Modified:
7 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, mmenke, Paweł Hajdan Jr.
Visibility:
Public.

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor in net/. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Linux in the net/ directory. BUG=173286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -68 lines) Patch
M net/base/filter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/base/sdch_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/dns/dns_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/dns/dns_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_network_transaction.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/http/http_auth_handler_negotiate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_cache_transaction.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_spdy2_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_spdy3_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/http/http_stream_parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_transaction_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/socket/deterministic_socket_data_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/tcp_listen_socket_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_core.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 3 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
I randomly checked several files and they appear to be correctly formatted.
7 years, 6 months ago (2013-06-12 03:50:36 UTC) #1
dcheng
(Note that after finding some now-empty #ifdefs for another patch, I went through all the ...
7 years, 6 months ago (2013-06-12 04:11:26 UTC) #2
Ryan Sleevi
lgtm
7 years, 6 months ago (2013-06-12 18:04:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16434016/1
7 years, 6 months ago (2013-06-12 18:04:34 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, chrome_frame_net_tests, ...
7 years, 6 months ago (2013-06-12 18:59:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/16434016/1
7 years, 6 months ago (2013-06-12 19:09:10 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 22:53:03 UTC) #7
Message was sent while issue was closed.
Change committed as 205961

Powered by Google App Engine
This is Rietveld 408576698