net/dns/dns_socket_pool.cc - Issue 16434016: Rewrite scoped_ptr<T>(NULL) to use the default ctor in net/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_socket_pool.cc

Issue 16434016: Rewrite scoped_ptr<T>(NULL) to use the default ctor in net/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/dns_socket_pool.cc

diff --git a/net/dns/dns_socket_pool.cc b/net/dns/dns_socket_pool.cc

index cc6552eea29b14dfcdfaa59eb95f7d768fe3117c..64570fca8fc83e295eb74c909f4bd363811b0aa4 100644

--- a/net/dns/dns_socket_pool.cc

+++ b/net/dns/dns_socket_pool.cc

@@ -187,7 +187,7 @@ scoped_ptr<DatagramClientSocket> DefaultDnsSocketPool::AllocateSocket(

FillPool(server_index, kAllocateMinSize);

if (pool.size() == 0) {

LOG(WARNING) << "No DNS sockets available in pool " << server_index << "!";

- return scoped_ptr<DatagramClientSocket>(NULL);

+ return scoped_ptr<DatagramClientSocket>();

}

if (pool.size() < kAllocateMinSize) {

« no previous file with comments | « net/dns/dns_session.cc ('k') | net/dns/dns_transaction_unittest.cc » ('j') | no next file with comments »