Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16431009: Use a direct include of strings headers in ui/, part 2. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, penghuang+watch_chromium.org, sail+watch_chromium.org, nona+watch_chromium.org, cc-bugs_chromium.org, James Su
Visibility:
Public.

Description

Use a direct include of strings headers in ui/, part 2. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205608

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -78 lines) Patch
M ui/base/models/button_menu_item_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/combobox_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/dialog_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/list_selection_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/simple_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/table_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/tree_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/tree_node_model.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/models/tree_node_model_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ozone/event_factory_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/range/range.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/text/bytes_formatting.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/text/bytes_formatting.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/text/text_elider.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/text/text_elider.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/text/text_elider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/text/utf16_indexing.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/touch/touch_factory_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/hwnd_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/hwnd_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/ime_input.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/win/ime_input.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/win/message_box_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/shell.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/win/window_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/x11_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/rect_base_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/rect_f.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/selection_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/shadow_value.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/size.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/size_f.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/text_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/transform.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/vector2d.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/vector2d_f.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/vector3d_f.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_implementation_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/notification_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/message_center/message_center_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/notification.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/notification_list.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/notification_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/notifier_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/bounded_label.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/bounded_label_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notifier_settings_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/oak/oak_aura_window_display.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/oak/oak_pretty_print.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/oak/oak_pretty_print.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/shell_dialogs/gtk/select_file_dialog_impl_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/gtk/select_file_dialog_impl_kde.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/selected_file_info.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/surface/accelerated_surface_transformer_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/surface/accelerated_surface_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16431009/1
7 years, 6 months ago (2013-06-10 23:13:25 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160852
7 years, 6 months ago (2013-06-11 05:15:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16431009/18001
7 years, 6 months ago (2013-06-11 15:07:51 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 19:48:43 UTC) #4
Message was sent while issue was closed. 
Change committed as 205608

Powered by Google App Engine
This is Rietveld 408576698