Issue 16421004: Use a direct include of strings headers in chrome/installer/, part 2.

Issue 16421004: Use a direct include of strings headers in chrome/installer/, part 2. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)

Modified:
7 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, grt+watch_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use a direct include of strings headers in chrome/installer/, part 2. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205431

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -37 lines)			Patch
M	chrome/installer/util/google_update_experiment_util.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/google_update_experiment_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/google_update_settings.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/google_update_settings.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/google_update_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/install_util.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/install_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/install_util_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/installation_state.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/installation_validator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/installer_state.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/installer_state_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/installer_util_test_common.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/l10n_string_util.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/l10n_string_util.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/language_selector.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/logging_installer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/master_preferences.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/master_preferences_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/move_tree_work_item_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/product_operations.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/self_reg_work_item.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/set_reg_value_work_item.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/set_reg_value_work_item_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/shell_util.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/shell_util.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/shell_util_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/uninstall_metrics.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/uninstall_metrics_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/user_experiment.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/user_experiment.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/wmi.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/work_item_list_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16421004/1

7 years, 6 months ago (2013-06-10 19:45:48 UTC) #1

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=48294

7 years, 6 months ago (2013-06-11 00:24:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16421004/1

7 years, 6 months ago (2013-06-11 00:34:49 UTC) #3

Message was sent while issue was closed.

Change committed as 205431

Expand Messages | Collapse Messages