Issue 16404004: Revert 204313 "net_watcher does not build in Ubuntu 13.04"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16404004: Revert 204313 "net_watcher does not build in Ubuntu 13.04" (Closed)

Created:
7 years, 6 months ago by kkania

Modified:
7 years, 6 months ago

Reviewers:
yael.aharon

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 204313 "net_watcher does not build in Ubuntu 13.04" broke compile on Google Chrome Linux bot: ../../net/tools/net_watcher/net_watcher.cc:133:error: expected [error|warning|ignored] after '#pragma GCC diagnostic' ../../net/tools/net_watcher/net_watcher.cc:207:error: expected [error|warning|ignored] after '#pragma GCC diagnostic' > net_watcher does not build in Ubuntu 13.04 > > This is due to a deprecation warning in glib, which affects glib 2.36 onward. Added a pragma to suppress deprecation warnings. > BUG=245658 > > Review URL: https://chromiumcodereview.appspot.com/15994010 TBR=yael.aharon@intel.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204338

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	trunk/src/net/tools/net_watcher/net_watcher.cc	View		2 chunks	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r204338.

Expand Messages | Collapse Messages