Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 15994010: net_watcher does not build in Ubuntu 13.04 (Closed)

Created:
7 years, 6 months ago by yael.aharon
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

net_watcher does not build in Ubuntu 13.04 This is due to a deprecation warning in glib, which affects glib 2.36 onward. Added a pragma to suppress deprecation warnings. BUG=245658 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204313

Patch Set 1 #

Patch Set 2 : Add ifdef around the pragma for the windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M net/tools/net_watcher/net_watcher.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yael.aharon1
As noted in https://codereview.chromium.org/15792013/ , the pragma cannot be inside a function, so I moved ...
7 years, 6 months ago (2013-06-04 12:18:24 UTC) #1
yael.aharon1
7 years, 6 months ago (2013-06-04 20:17:01 UTC) #2
jar (doing other things)
lgtm
7 years, 6 months ago (2013-06-04 23:55:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/15994010/1
7 years, 6 months ago (2013-06-05 00:22:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/15994010/8002
7 years, 6 months ago (2013-06-05 12:22:23 UTC) #5
commit-bot: I haz the power
Change committed as 204313
7 years, 6 months ago (2013-06-05 19:06:27 UTC) #6
Lei Zhang
7 years, 6 months ago (2013-06-06 00:34:48 UTC) #7
Message was sent while issue was closed.
Reverted due to Lucid bot failing:

../../net/tools/net_watcher/net_watcher.cc:133: error: expected
[error|warning|ignored] after '#pragma GCC diagnostic'
../../net/tools/net_watcher/net_watcher.cc:207: error: expected
[error|warning|ignored] after '#pragma GCC diagnostic'

gcc 4.4.3 on Lucid does not understand the pop and push #pragmas.

Instead of rolling your own #pragmas, try using G_GNUC_BEGIN_IGNORE_DEPRECATIONS
and G_GNUC_END_IGNORE_DEPRECATIONS instead. They seem designed for the exact
problem you are trying to solve.

Powered by Google App Engine
This is Rietveld 408576698