Move some extension manifest consistency checks to BackgroundManifestHandler.

chrome/common/extensions/background_info.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/background_info.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 61 matching lines @@
   return GetBackgroundInfo(extension).has_background_page();
 }
 
 // static
 bool BackgroundInfo::AllowJSAccess(const Extension* extension) {
   return GetBackgroundInfo(extension).allow_js_access_;
 }
 
 // static
 bool BackgroundInfo::HasPersistentBackgroundPage(const Extension* extension)  {
-  const BackgroundInfo& info = GetBackgroundInfo(extension);
-  return info.has_background_page() && info.is_persistent_;
+  return GetBackgroundInfo(extension).has_persistent_background_page();
 }
 
 // static
 bool BackgroundInfo::HasLazyBackgroundPage(const Extension* extension) {
-  const BackgroundInfo& info = GetBackgroundInfo(extension);
-  return info.has_background_page() && !info.is_persistent_;
+  return GetBackgroundInfo(extension).has_lazy_background_page();
 }
 
 bool BackgroundInfo::Parse(const Extension* extension, string16* error) {
   const std::string& bg_scripts_key = extension->is_platform_app() ?
       keys::kPlatformAppBackgroundScripts : keys::kBackgroundScripts;
   if (!LoadBackgroundScripts(extension, bg_scripts_key, error) ||
       !LoadBackgroundPage(extension, error) ||
       !LoadBackgroundPersistent(extension, error) ||
       !LoadAllowJSAccess(extension, error)) {
     return false;
@@ skipping 133 matching lines @@
 BackgroundManifestHandler::BackgroundManifestHandler() {
 }
 
 BackgroundManifestHandler::~BackgroundManifestHandler() {
 }
 
 bool BackgroundManifestHandler::Parse(Extension* extension, string16* error) {
   scoped_ptr<BackgroundInfo> info(new BackgroundInfo);
   if (!info->Parse(extension, error))
     return false;
+
+  // Platform apps must have background pages.
+  if (extension->is_platform_app() && !info->has_background_page()) {
+    *error = ASCIIToUTF16(errors::kBackgroundRequiredForPlatformApps);
+    return false;
+  }
+  // Lazy background pages are incompatible with the webRequest API.
+  if (info->has_lazy_background_page() &&
+      PermissionsData::GetInitialAPIPermissions(extension)->count(
+          APIPermission::kWebRequest)) {
+    *error = ASCIIToUTF16(errors::kWebRequestConflictsWithLazyBackground);
+    return false;
+  }
+
   extension->SetManifestData(kBackground, info.release());
   return true;
 }
 
 bool BackgroundManifestHandler::Validate(
     const Extension* extension,
     std::string* error,
     std::vector<InstallWarning>* warnings) const {
   // Validate that background scripts exist.
   const std::vector<std::string>& background_scripts =
@@ skipping 21 matching lines @@
       *error =
           l10n_util::GetStringFUTF8(
               IDS_EXTENSION_LOAD_BACKGROUND_PAGE_FAILED,
               page_path.LossyDisplayName());
       return false;
     }
   }
   return true;
 }
 
+bool BackgroundManifestHandler::AlwaysParseForType(Manifest::Type type) const {
+  return type == Manifest::TYPE_PLATFORM_APP;
+}
+
 const std::vector<std::string> BackgroundManifestHandler::Keys() const {
   static const char* keys[] = {
     keys::kBackgroundAllowJsAccess,
     keys::kBackgroundPage,
     keys::kBackgroundPageLegacy,
     keys::kBackgroundPersistent,
     keys::kBackgroundScripts,
     keys::kPlatformAppBackgroundPage,
     keys::kPlatformAppBackgroundScripts
   };
   return std::vector<std::string>(keys, keys + arraysize(keys));
 }
 
-}  // extensions
+}  // namespace extensions