Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 16398010: Move some extension manifest consistency checks to BackgroundManifestHandler. (Closed)

Created:
7 years, 6 months ago by Yoyo Zhou
Modified:
7 years, 6 months ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move some extension manifest consistency checks to BackgroundManifestHandler. BUG=162530 TBR=rdsmith@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204990

Patch Set 1 #

Total comments: 5

Patch Set 2 : rm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -55 lines) Patch
M chrome/browser/download/download_crx_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/background_info.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/common/extensions/background_info.cc View 1 4 chunks +21 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/common/extensions/extension.cc View 3 chunks +0 lines, -39 lines 0 comments Download
M chrome/common/extensions/extension_manifest_constants.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_manifest_constants.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoyo Zhou
https://chromiumcodereview.appspot.com/16398010/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (left): https://chromiumcodereview.appspot.com/16398010/diff/1/chrome/common/extensions/extension.cc#oldcode836 chrome/common/extensions/extension.cc:836: if (!IncognitoInfo::IsSplitMode(this)) { This is unnecessary because of manifest_features.
7 years, 6 months ago (2013-06-07 02:01:43 UTC) #1
Matt Perry
lgtm https://chromiumcodereview.appspot.com/16398010/diff/1/chrome/browser/download/download_crx_util.cc File chrome/browser/download/download_crx_util.cc (right): https://chromiumcodereview.appspot.com/16398010/diff/1/chrome/browser/download/download_crx_util.cc#newcode19 chrome/browser/download/download_crx_util.cc:19: #include "chrome/common/extensions/user_script.h" Why did you add this in ...
7 years, 6 months ago (2013-06-07 20:32:03 UTC) #2
Yoyo Zhou
https://chromiumcodereview.appspot.com/16398010/diff/1/chrome/browser/download/download_crx_util.cc File chrome/browser/download/download_crx_util.cc (right): https://chromiumcodereview.appspot.com/16398010/diff/1/chrome/browser/download/download_crx_util.cc#newcode19 chrome/browser/download/download_crx_util.cc:19: #include "chrome/common/extensions/user_script.h" On 2013/06/07 20:32:03, Matt Perry wrote: > ...
7 years, 6 months ago (2013-06-07 21:05:16 UTC) #3
Yoyo Zhou
TBR=rdsmith@chromium.org for change to #includes in download_crx_util
7 years, 6 months ago (2013-06-07 21:05:56 UTC) #4
Yoyo Zhou
actually now TBR=rdsmith
7 years, 6 months ago (2013-06-07 21:06:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/16398010/5001
7 years, 6 months ago (2013-06-07 21:06:42 UTC) #6
Randy Smith (Not in Mondays)
download_crx_util.cc LGTM.
7 years, 6 months ago (2013-06-07 23:50:37 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-08 00:31:10 UTC) #8
Message was sent while issue was closed.
Change committed as 204990

Powered by Google App Engine
This is Rietveld 408576698