Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/common/extensions/extension.h

Issue 16398010: Move some extension manifest consistency checks to BackgroundManifestHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
7 7
8 #include <algorithm> 8 #include <algorithm>
9 #include <iosfwd> 9 #include <iosfwd>
10 #include <map> 10 #include <map>
11 #include <set> 11 #include <set>
12 #include <string> 12 #include <string>
13 #include <utility> 13 #include <utility>
14 #include <vector> 14 #include <vector>
15 15
16 #include "base/files/file_path.h" 16 #include "base/files/file_path.h"
17 #include "base/hash_tables.h" 17 #include "base/hash_tables.h"
18 #include "base/memory/linked_ptr.h" 18 #include "base/memory/linked_ptr.h"
19 #include "base/memory/ref_counted.h" 19 #include "base/memory/ref_counted.h"
20 #include "base/memory/scoped_ptr.h" 20 #include "base/memory/scoped_ptr.h"
21 #include "base/synchronization/lock.h" 21 #include "base/synchronization/lock.h"
22 #include "base/threading/thread_checker.h" 22 #include "base/threading/thread_checker.h"
23 #include "chrome/common/extensions/extension_constants.h" 23 #include "chrome/common/extensions/extension_constants.h"
24 #include "chrome/common/extensions/manifest.h" 24 #include "chrome/common/extensions/manifest.h"
25 #include "chrome/common/extensions/permissions/api_permission.h" 25 #include "chrome/common/extensions/permissions/api_permission.h"
26 #include "chrome/common/extensions/permissions/permission_message.h" 26 #include "chrome/common/extensions/permissions/permission_message.h"
27 #include "chrome/common/extensions/user_script.h"
28 #include "extensions/common/extension_resource.h" 27 #include "extensions/common/extension_resource.h"
29 #include "extensions/common/install_warning.h" 28 #include "extensions/common/install_warning.h"
30 #include "extensions/common/url_pattern.h" 29 #include "extensions/common/url_pattern.h"
31 #include "extensions/common/url_pattern_set.h" 30 #include "extensions/common/url_pattern_set.h"
32 #include "googleurl/src/gurl.h" 31 #include "googleurl/src/gurl.h"
33 #include "ui/base/accelerators/accelerator.h" 32 #include "ui/base/accelerators/accelerator.h"
34 #include "ui/gfx/size.h" 33 #include "ui/gfx/size.h"
35 34
36 class ExtensionAction; 35 class ExtensionAction;
37 class SkBitmap; 36 class SkBitmap;
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 const char* list_error, 364 const char* list_error,
366 const char* value_error, 365 const char* value_error,
367 string16* error); 366 string16* error);
368 367
369 bool LoadSharedFeatures(string16* error); 368 bool LoadSharedFeatures(string16* error);
370 bool LoadDescription(string16* error); 369 bool LoadDescription(string16* error);
371 bool LoadManifestVersion(string16* error); 370 bool LoadManifestVersion(string16* error);
372 371
373 bool CheckMinimumChromeVersion(string16* error) const; 372 bool CheckMinimumChromeVersion(string16* error) const;
374 373
375 // Check that platform app features are valid. Called after InitFromValue.
376 bool CheckPlatformAppFeatures(string16* error) const;
377
378 // Check that features don't conflict. Called after InitFromValue.
379 bool CheckConflictingFeatures(string16* error) const;
380
381 // The extension's human-readable name. Name is used for display purpose. It 374 // The extension's human-readable name. Name is used for display purpose. It
382 // might be wrapped with unicode bidi control characters so that it is 375 // might be wrapped with unicode bidi control characters so that it is
383 // displayed correctly in RTL context. 376 // displayed correctly in RTL context.
384 // NOTE: Name is UTF-8 and may contain non-ascii characters. 377 // NOTE: Name is UTF-8 and may contain non-ascii characters.
385 std::string name_; 378 std::string name_;
386 379
387 // A non-localized version of the extension's name. This is useful for 380 // A non-localized version of the extension's name. This is useful for
388 // debug output. 381 // debug output.
389 std::string non_localized_name_; 382 std::string non_localized_name_;
390 383
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 517
525 UpdatedExtensionPermissionsInfo( 518 UpdatedExtensionPermissionsInfo(
526 const Extension* extension, 519 const Extension* extension,
527 const PermissionSet* permissions, 520 const PermissionSet* permissions,
528 Reason reason); 521 Reason reason);
529 }; 522 };
530 523
531 } // namespace extensions 524 } // namespace extensions
532 525
533 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_H_ 526 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698