MacViews: Fix views_unittests BubbleDelegateTest.CloseReasons

ui/views/bubble/bubble_delegate_unittest.cc

Index: ui/views/bubble/bubble_delegate_unittest.cc
diff --git a/ui/views/bubble/bubble_delegate_unittest.cc b/ui/views/bubble/bubble_delegate_unittest.cc
index 92201c0882a308cb08bee89482943f5a95868851..f04cf1c3de5363fd3db4c2b94ee186b6f5ec781c 100644
--- a/ui/views/bubble/bubble_delegate_unittest.cc
+++ b/ui/views/bubble/bubble_delegate_unittest.cc
@@ -15,6 +15,10 @@
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_observer.h"
 
+#if defined(OS_MACOSX)
+#include "ui/base/test/scoped_fake_nswindow_focus.h"
+#endif
+
 namespace views {
 
 namespace {
@@ -66,6 +70,10 @@ class BubbleDelegateTest : public ViewsTestBase {
   }
 
  private:
+#if defined(OS_MACOSX)
+  ui::test::ScopedFakeNSWindowFocus fake_focus;
+#endif
+
   DISALLOW_COPY_AND_ASSIGN(BubbleDelegateTest);
 };
 
@@ -278,6 +286,7 @@ TEST_F(BubbleDelegateTest, CloseReasons) {
     bubble_delegate->set_close_on_deactivate(true);
     Widget* bubble_widget = BubbleDelegateView::CreateBubble(bubble_delegate);
     bubble_widget->Show();
+    EXPECT_TRUE(bubble_widget->IsVisible());

[tapted, 2016/03/01 02:42:39]

OK - so the reason this currently works on Aura is some code in
NativeWidgetAura::InitNativeWidget()


  gfx::NativeView parent = params.parent;
  if (!params.child) {
    ..
    if (parent && parent->type() != ui::wm::WINDOW_TYPE_UNKNOWN) {
      ..
      parent = NULL;
    }
    ..
  }

  if (parent) {
    parent->AddChild(window_);
  } else {
    ..
  }

i.e. for a top-level widget (child = false), the `parent` is removed, and it's
not added as a ChildWindow as far as Aura::Window::IsVisible(..) is concerned.


So I think we can say here

#if defined(USE_AURA)
  // Bubbles are top-level which, on Aura, causes the parent->child
  // relationship to be managed by wm::TransientWindowManager
  // rather than the ui::Layer hierarchy. TransientWindowManager
  // currently permits a child to be shown when its parent is hidden,
  // but it shouldn't. This is http://crbug.com/XXXXX.
  EXPECT_TRUE(bubble_widget->IsVisible());
#else
  EXPECT_FALSE(bubble_widget->IsVisible());
#endif

anchor_widget->Show();
EXPECT_TRUE(bubble_widget->IsVisible());

[Patti Lor, 2016/03/01 06:54:48]

Done, have also applied the same ifdefs to the IsClosed() and CloseReason
checks.

     anchor_widget->Activate();
     EXPECT_TRUE(bubble_widget->IsClosed());
     EXPECT_EQ(BubbleDelegateView::CloseReason::DEACTIVATION,