MacViews: Fix views_unittests BubbleDelegateTest.CloseReasons

ui/views/bubble/bubble_delegate.cc

Index: ui/views/bubble/bubble_delegate.cc
diff --git a/ui/views/bubble/bubble_delegate.cc b/ui/views/bubble/bubble_delegate.cc
index a18c08888d20d3a2d1154053073c25be19b34327..250ac499f163c3bfab2e2690b6c44da15144eff0 100644
--- a/ui/views/bubble/bubble_delegate.cc
+++ b/ui/views/bubble/bubble_delegate.cc
@@ -38,6 +38,7 @@ Widget* CreateBubbleWidget(BubbleDelegateView* bubble) {
     bubble_params.parent = bubble->anchor_widget()->GetNativeView();
   bubble_params.activatable = bubble->CanActivate() ?
       Widget::InitParams::ACTIVATABLE_YES : Widget::InitParams::ACTIVATABLE_NO;
+  bubble_params.child = true;
   bubble->OnBeforeBubbleWidgetInit(&bubble_params, bubble_widget);
   bubble_widget->Init(bubble_params);
   if (bubble_params.parent)
@@ -177,7 +178,9 @@ void BubbleDelegateView::OnWidgetVisibilityChanged(Widget* widget,
 
 void BubbleDelegateView::OnWidgetActivationChanged(Widget* widget,
                                                    bool active) {
-  if (close_on_deactivate() && widget == GetWidget() && !active) {
+  // Only close the widget if it's been shown in the first place.

[tapted, 2016/03/01 02:42:39]

Was this necessary to get the test to pass? Otherwise hopefully we can avoid it
since I will need to think more about it

[Patti Lor, 2016/03/01 06:54:48]

Have reverted this. The child = true change prevented the bubble being shown
without having shown the anchor, but it still closed on deactivation, so I added
the check to prevent it from closing when it wasn't even visible. I think this
is actually wrong though because the bubble was active without being visible.

+  if (close_on_deactivate() && widget == GetWidget() && !active &&
+      GetWidget()->IsActive()) {
     if (close_reason_ == CloseReason::UNKNOWN)
       close_reason_ = CloseReason::DEACTIVATION;
     GetWidget()->Close();