Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: lib/src/rules.dart

Issue 1636873007: Check for return types on setters (#122). (Closed) Base URL: https://github.com/dart-lang/linter.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | lib/src/rules/avoid_return_types_on_setters.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library linter.src.rules; 5 library linter.src.rules;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 import 'package:linter/src/config.dart'; 9 import 'package:linter/src/config.dart';
10 import 'package:linter/src/linter.dart'; 10 import 'package:linter/src/linter.dart';
11 import 'package:linter/src/rules/always_declare_return_types.dart'; 11 import 'package:linter/src/rules/always_declare_return_types.dart';
12 import 'package:linter/src/rules/always_specify_types.dart'; 12 import 'package:linter/src/rules/always_specify_types.dart';
13 import 'package:linter/src/rules/avoid_as.dart'; 13 import 'package:linter/src/rules/avoid_as.dart';
14 import 'package:linter/src/rules/avoid_empty_else.dart'; 14 import 'package:linter/src/rules/avoid_empty_else.dart';
15 import 'package:linter/src/rules/avoid_return_types_on_setters.dart';
15 import 'package:linter/src/rules/camel_case_types.dart'; 16 import 'package:linter/src/rules/camel_case_types.dart';
16 import 'package:linter/src/rules/constant_identifier_names.dart'; 17 import 'package:linter/src/rules/constant_identifier_names.dart';
17 import 'package:linter/src/rules/empty_constructor_bodies.dart'; 18 import 'package:linter/src/rules/empty_constructor_bodies.dart';
18 import 'package:linter/src/rules/implementation_imports.dart'; 19 import 'package:linter/src/rules/implementation_imports.dart';
19 import 'package:linter/src/rules/library_names.dart'; 20 import 'package:linter/src/rules/library_names.dart';
20 import 'package:linter/src/rules/library_prefixes.dart'; 21 import 'package:linter/src/rules/library_prefixes.dart';
21 import 'package:linter/src/rules/non_constant_identifier_names.dart'; 22 import 'package:linter/src/rules/non_constant_identifier_names.dart';
22 import 'package:linter/src/rules/one_member_abstracts.dart'; 23 import 'package:linter/src/rules/one_member_abstracts.dart';
23 import 'package:linter/src/rules/package_api_docs.dart'; 24 import 'package:linter/src/rules/package_api_docs.dart';
24 import 'package:linter/src/rules/package_prefixed_library_names.dart'; 25 import 'package:linter/src/rules/package_prefixed_library_names.dart';
25 import 'package:linter/src/rules/prefer_is_not_empty.dart'; 26 import 'package:linter/src/rules/prefer_is_not_empty.dart';
26 import 'package:linter/src/rules/pub/package_names.dart'; 27 import 'package:linter/src/rules/pub/package_names.dart';
27 import 'package:linter/src/rules/slash_for_doc_comments.dart'; 28 import 'package:linter/src/rules/slash_for_doc_comments.dart';
28 import 'package:linter/src/rules/super_goes_last.dart'; 29 import 'package:linter/src/rules/super_goes_last.dart';
29 import 'package:linter/src/rules/type_annotate_public_apis.dart'; 30 import 'package:linter/src/rules/type_annotate_public_apis.dart';
30 import 'package:linter/src/rules/type_init_formals.dart'; 31 import 'package:linter/src/rules/type_init_formals.dart';
31 import 'package:linter/src/rules/unnecessary_brace_in_string_interp.dart'; 32 import 'package:linter/src/rules/unnecessary_brace_in_string_interp.dart';
32 import 'package:linter/src/rules/unnecessary_getters_setters.dart'; 33 import 'package:linter/src/rules/unnecessary_getters_setters.dart';
33 34
34 final Registry ruleRegistry = new Registry() 35 final Registry ruleRegistry = new Registry()
35 ..register(new AlwaysDeclareReturnTypes()) 36 ..register(new AlwaysDeclareReturnTypes())
36 ..register(new AlwaysSpecifyTypes()) 37 ..register(new AlwaysSpecifyTypes())
37 ..register(new AvoidAs()) 38 ..register(new AvoidAs())
38 ..register(new AvoidEmptyElse()) 39 ..register(new AvoidEmptyElse())
40 ..register(new AvoidReturnTypesOnSetters())
39 ..register(new CamelCaseTypes()) 41 ..register(new CamelCaseTypes())
40 ..register(new ConstantIdentifierNames()) 42 ..register(new ConstantIdentifierNames())
41 ..register(new EmptyConstructorBodies()) 43 ..register(new EmptyConstructorBodies())
42 ..register(new ImplementationImports()) 44 ..register(new ImplementationImports())
43 ..register(new LibraryNames()) 45 ..register(new LibraryNames())
44 ..register(new LibraryPrefixes()) 46 ..register(new LibraryPrefixes())
45 ..register(new NonConstantIdentifierNames()) 47 ..register(new NonConstantIdentifierNames())
46 ..register(new PreferIsNotEmpty()) 48 ..register(new PreferIsNotEmpty())
47 ..register(new OneMemberAbstracts()) 49 ..register(new OneMemberAbstracts())
48 ..register(new PackageApiDocs()) 50 ..register(new PackageApiDocs())
(...skipping 27 matching lines...) Expand all
76 /// enables `my_rule`. 78 /// enables `my_rule`.
77 /// 79 ///
78 /// Unspecified rules are treated as disabled by default. 80 /// Unspecified rules are treated as disabled by default.
79 Iterable<LintRule> enabled(LintConfig config) => rules 81 Iterable<LintRule> enabled(LintConfig config) => rules
80 .where((rule) => config.ruleConfigs.any((rc) => rc.enables(rule.name))); 82 .where((rule) => config.ruleConfigs.any((rc) => rc.enables(rule.name)));
81 83
82 void register(LintRule rule) { 84 void register(LintRule rule) {
83 _ruleMap[rule.name] = rule; 85 _ruleMap[rule.name] = rule;
84 } 86 }
85 } 87 }
OLDNEW
« no previous file with comments | « no previous file | lib/src/rules/avoid_return_types_on_setters.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698