Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1636873007: Check for return types on setters (#122). (Closed)

Created:
4 years, 11 months ago by pquitslund
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/linter.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M lib/src/rules.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A lib/src/rules/avoid_return_types_on_setters.dart View 1 chunk +60 lines, -0 lines 0 comments Download
A test/rules/avoid_return_types_on_setters.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
4 years, 11 months ago (2016-01-27 00:19:32 UTC) #2
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-27 01:27:18 UTC) #3
pquitslund
4 years, 11 months ago (2016-01-27 18:51:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0909e06deb557b085fc5a2e1ccc98b16454d16fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698