Issue 16360007: [content shell] don't leak the devtools delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16360007: [content shell] don't leak the devtools delegate (Closed)

Created:
7 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 6 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, glider+watch_chromium.org, jochen+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[content shell] don't leak the devtools delegate BUG=246359 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204033

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -16 lines)			Patch
M	content/shell/shell_browser_main_parts.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/shell/shell_browser_main_parts.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/16360007/1

7 years, 6 months ago (2013-06-04 14:59:30 UTC) #3

Message was sent while issue was closed.

Change committed as 204033

Expand Messages | Collapse Messages