Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: content/shell/shell_browser_main_parts.h

Issue 16360007: [content shell] don't leak the devtools delegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/shell_browser_main_parts.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/shell_browser_main_parts.h
diff --git a/content/shell/shell_browser_main_parts.h b/content/shell/shell_browser_main_parts.h
index 334ee03d177da277e9a7593bbed45a7c241746e2..ab8dbce0ceb4fe3bd27435288809ee54c41387eb 100644
--- a/content/shell/shell_browser_main_parts.h
+++ b/content/shell/shell_browser_main_parts.h
@@ -33,7 +33,9 @@ class ShellBrowserMainParts : public BrowserMainParts {
virtual bool MainMessageLoopRun(int* result_code) OVERRIDE;
virtual void PostMainMessageLoopRun() OVERRIDE;
- ShellDevToolsDelegate* devtools_delegate() { return devtools_delegate_; }
+ ShellDevToolsDelegate* devtools_delegate() {
+ return devtools_delegate_.get();
+ }
ShellBrowserContext* browser_context() { return browser_context_.get(); }
ShellBrowserContext* off_the_record_browser_context() {
@@ -48,7 +50,7 @@ class ShellBrowserMainParts : public BrowserMainParts {
const MainFunctionParams& parameters_;
bool run_message_loop_;
- ShellDevToolsDelegate* devtools_delegate_;
+ scoped_ptr<ShellDevToolsDelegate> devtools_delegate_;
#if defined(ENABLE_PLUGINS)
scoped_ptr<ShellPluginServiceFilter> plugin_service_filter_;
#endif
« no previous file with comments | « no previous file | content/shell/shell_browser_main_parts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698