Issue 16355009: Rewrite scoped_ptr<T>(NULL) to use the default ctor in cc/.

Issue 16355009: Rewrite scoped_ptr<T>(NULL) to use the default ctor in cc/. (Closed)

Created:
7 years, 6 months ago by dcheng

Modified:
7 years, 6 months ago

Reviewers:
jamesr, enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org, danakj

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Rewrite scoped_ptr<T>(NULL) to use the default ctor in cc/. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Linux in the cc/ directory. BUG=173286 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205810

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -27 lines)			Patch
M	cc/base/scoped_ptr_hash_map.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	cc/base/scoped_ptr_vector.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/layers/delegated_renderer_layer_impl_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/layers/layer_unittest.cc	View		2 chunks	+5 lines, -7 lines	0 comments	Download
M	cc/layers/nine_patch_layer_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/layers/scrollbar_layer_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/layers/texture_layer_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/layers/tiled_layer_unittest.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	cc/resources/prioritized_resource_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/resources/resource_update_controller_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/test/layer_tree_test.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	cc/trees/layer_tree_host_impl_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/trees/layer_tree_host_unittest_context.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/trees/single_thread_proxy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/trees/tree_synchronizer_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (0 generated)

dcheng

It looks like clang-format didn't like how LayoutTreeHost::Create was aligned. If it is objectionable, I ...

7 years, 6 months ago (2013-06-12 03:59:47 UTC) #1

jamesr

We generally like clang-format 'round these parts, although the orphan .Pass() is somewhat odd. I ...

7 years, 6 months ago (2013-06-12 04:04:38 UTC) #2