cc/base/scoped_ptr_vector.h - Issue 16355009: Rewrite scoped_ptr<T>(NULL) to use the default ctor in cc/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/base/scoped_ptr_vector.h

Issue 16355009: Rewrite scoped_ptr<T>(NULL) to use the default ctor in cc/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix most vexing parse Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/base/scoped_ptr_vector.h

diff --git a/cc/base/scoped_ptr_vector.h b/cc/base/scoped_ptr_vector.h

index 8cd368d885ce3f72a2b962c06b2958fa4ba05dec..856e2f51cd1f26607a6500401fc08e43cc015093 100644

--- a/cc/base/scoped_ptr_vector.h

+++ b/cc/base/scoped_ptr_vector.h

@@ -72,7 +72,7 @@ class ScopedPtrVector {

scoped_ptr<T> take(iterator position) {

if (position == end())

- return scoped_ptr<T>(NULL);

+ return scoped_ptr<T>();

DCHECK(position < end());

typename std::vector<T*>::iterator writable_position = position;

« no previous file with comments | « cc/base/scoped_ptr_hash_map.h ('k') | cc/layers/delegated_renderer_layer_impl_unittest.cc » ('j') | no next file with comments »