Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 16344006: Use a direct include of strings headers in base/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in base/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M base/i18n/bidi_line_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/break_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/break_iterator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/case_conversion.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/case_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/char_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/file_util_icu.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/file_util_icu.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_encoding_detection.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_string_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_string_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_string_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/number_formatting.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/number_formatting.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/i18n/rtl.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/rtl.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/rtl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/string_compare.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/string_search.h View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/string_search_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/time_formatting.h View 1 chunk +1 line, -1 line 0 comments Download
M base/ios/device_util.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M base/json/json_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/process/internal_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_iterator_freebsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_iterator_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_iterator_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_iterator_openbsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process/process_metrics_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_freebsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_openbsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16344006/1
7 years, 6 months ago (2013-06-10 14:45:04 UTC) #1
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=160442
7 years, 6 months ago (2013-06-10 18:14:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16344006/1
7 years, 6 months ago (2013-06-10 18:21:06 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-10 21:07:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16344006/1
7 years, 6 months ago (2013-06-10 21:12:18 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 21:17:41 UTC) #6
Message was sent while issue was closed.
Change committed as 205309

Powered by Google App Engine
This is Rietveld 408576698