Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 16325018: GPU: Factory produces APTManagers instead of APTDelegates (Closed)

Created:
7 years, 6 months ago by jonathan.backer
Modified:
7 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, sail+watch_chromium.org, apatrick_chromium
Visibility:
Public.

Description

GPU: Factory produces APTManagers instead of APTDelegates First step of a larger refactor to push some of the logic from the AsyncPixelTransferDelegate to the AsyncPixelTransferManager. This CL moves a lot of files (async_pixel_transfer_delegate_* --> async_pixel_transfer_manager_*) and introduces some Manager wrappers. There is no functional change. BUG=240504 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -2315 lines) Patch
M gpu/command_buffer/service/async_pixel_transfer_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_android.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_egl.h View 1 chunk +0 lines, -77 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_egl.cc View 1 chunk +0 lines, -751 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_idle.h View 1 chunk +0 lines, -86 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_idle.cc View 1 chunk +0 lines, -299 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_linux.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_mac.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_share_group.h View 1 chunk +0 lines, -58 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_share_group.cc View 1 chunk +0 lines, -504 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_stub.h View 1 chunk +0 lines, -47 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_stub.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_sync.h View 1 chunk +0 lines, -51 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_sync.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D gpu/command_buffer/service/async_pixel_transfer_delegate_win.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager.h View 2 chunks +7 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager.cc View 1 chunk +9 lines, -9 lines 0 comments Download
A + gpu/command_buffer/service/async_pixel_transfer_manager_android.cc View 3 chunks +9 lines, -9 lines 0 comments Download
A gpu/command_buffer/service/async_pixel_transfer_manager_egl.h View 1 chunk +30 lines, -0 lines 0 comments Download
A + gpu/command_buffer/service/async_pixel_transfer_manager_egl.cc View 4 chunks +73 lines, -1 line 0 comments Download
A gpu/command_buffer/service/async_pixel_transfer_manager_idle.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc View 3 chunks +82 lines, -1 line 0 comments Download
A + gpu/command_buffer/service/async_pixel_transfer_manager_linux.cc View 1 chunk +10 lines, -10 lines 0 comments Download
A + gpu/command_buffer/service/async_pixel_transfer_manager_mac.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A gpu/command_buffer/service/async_pixel_transfer_manager_share_group.h View 1 chunk +34 lines, -0 lines 0 comments Download
A + gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc View 3 chunks +54 lines, -1 line 0 comments Download
A gpu/command_buffer/service/async_pixel_transfer_manager_stub.h View 1 chunk +30 lines, -0 lines 0 comments Download
A + gpu/command_buffer/service/async_pixel_transfer_manager_stub.cc View 3 chunks +46 lines, -2 lines 0 comments Download
A gpu/command_buffer/service/async_pixel_transfer_manager_sync.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + gpu/command_buffer/service/async_pixel_transfer_manager_sync.cc View 3 chunks +50 lines, -1 line 0 comments Download
A gpu/command_buffer/service/async_pixel_transfer_manager_test.h View 1 chunk +34 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/async_pixel_transfer_manager_test.cc View 1 chunk +23 lines, -0 lines 0 comments Download
A + gpu/command_buffer/service/async_pixel_transfer_manager_win.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M gpu/command_buffer_service.gypi View 2 chunks +14 lines, -14 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jonathan.backer
Keeping it small to make it easier to review. The next step is to move ...
7 years, 6 months ago (2013-06-03 21:11:27 UTC) #1
piman
lgtm
7 years, 6 months ago (2013-06-03 21:23:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/16325018/1
7 years, 6 months ago (2013-06-04 12:51:29 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 19:30:10 UTC) #4
Message was sent while issue was closed.
Change committed as 204017

Powered by Google App Engine
This is Rietveld 408576698