Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 16320013: IndexedDB: Remove prefetching method stubs from Blink (Closed)

Created:
7 years, 6 months ago by jsbell
Modified:
7 years, 6 months ago
CC:
blink-reviews, jamesr, eae+blinkwatch, abarth-chromium, dgrogan
Visibility:
Public.

Description

IndexedDB: Remove prefetching method stubs from Blink Prefetching is implemented entirely in Chromium (apart from the postSuccess... side of things); now that the backend is moved, various interfaces can be simplified and stubs removed. BUG=234278 R=abarth@chromium.org, alecflett@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152153

Patch Set 1 #

Patch Set 2 : Remove unintelligible comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M Source/WebKit/chromium/src/IDBCursorBackendProxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBCallbacks.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBCursorBackendInterface.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebIDBCallbacks.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebIDBCursor.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
alecflett@, jamesr@ - please take a look? All code deletion.
7 years, 6 months ago (2013-06-10 16:47:33 UTC) #1
alecflett
On 2013/06/10 16:47:33, jsbell wrote: > alecflett@, jamesr@ - please take a look? > > ...
7 years, 6 months ago (2013-06-10 16:50:11 UTC) #2
abarth-chromium
LGTM2
7 years, 6 months ago (2013-06-10 17:34:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/16320013/2001
7 years, 6 months ago (2013-06-10 17:35:25 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=9415
7 years, 6 months ago (2013-06-10 20:06:40 UTC) #5
jsbell
7 years, 6 months ago (2013-06-10 20:11:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r152153 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698