Issue 16320012: Use a direct include of strings headers in x/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16320012: Use a direct include of strings headers in x/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)

Modified:
7 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, James Su, akalin, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, markusheintz_, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, benjhayden+dwatch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Raghu Simha, chromium-apps-reviews_chromium.org, dcheng, ctguil+watch_chromium.org, haitaol1, tim (not reviewing), zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use a direct include of strings headers in x/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205334

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -46 lines)			Patch
M	chrome/browser/ui/views/about_ipc_dialog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/accessibility/accessibility_event_router_views.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/avatar_menu_bubble_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/cookie_info_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/cookie_info_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/download/download_item_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/download/download_item_view.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/edit_search_engine_dialog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/browser_action_drag_data.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_install_dialog_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/external_protocol_dialog.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/external_tab_container_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/find_bar_host_interactive_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/find_bar_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/find_bar_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/keyboard_access_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/icon_label_bubble_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/login_prompt_views.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/message_center/web_notification_tray.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/ssl_client_certificate_selector.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/status_bubble_views.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/status_bubble_views.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/sync/one_click_signin_bubble_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/stacked_tab_strip_layout_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_renderer_data.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/uninstall_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/website_settings/permission_selector_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/website_settings/website_settings_popup_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16320012/1

7 years, 6 months ago (2013-06-10 16:35:08 UTC) #1

Message was sent while issue was closed.

Change committed as 205334

Expand Messages | Collapse Messages