Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16320009: Use a direct include of strings headers in base/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sail+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in base/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M base/rand_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/latin1_string_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_number_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_piece.h View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_piece_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_split.h View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_split.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/strings/sys_string_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/sys_string_conversions_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/utf_offset_string_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/utf_string_conversion_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/utf_string_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/utf_string_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/utf_string_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/sys_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/expectations/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/perf_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_file_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_process_killer_win.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_process_killer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_shortcut_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_id_name_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/tracked_objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/values.h View 1 chunk +1 line, -1 line 0 comments Download
M base/values.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/values_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/metro.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/metro.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/scoped_bstr.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/shortcut.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/win_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/win_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/win/win_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/wrapped_window_proc.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16320009/1
7 years, 6 months ago (2013-06-10 14:46:11 UTC) #1
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=136357
7 years, 6 months ago (2013-06-10 16:49:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16320009/1
7 years, 6 months ago (2013-06-10 16:52:30 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=136462
7 years, 6 months ago (2013-06-10 17:44:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16320009/1
7 years, 6 months ago (2013-06-10 17:46:30 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 20:11:15 UTC) #6
Message was sent while issue was closed. 
Change committed as 205284

Powered by Google App Engine
This is Rietveld 408576698