Issue 16300008: Revert the about:ipc dialog to the old style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16300008: Revert the about:ipc dialog to the old style. (Closed)

Created:
7 years, 6 months ago by msw

Modified:
7 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert the about:ipc dialog to the old style. Override AboutIPCDialog::UseNewStyleForThisDialog to return false. Reverts the Windows IPC debugging utility dialog the old style. (this dialog's style was unintentionally updated; resize is needed) (its native list control cannot be rendered with the proper new style anyway) See before/after pics at http://crbug.com/246777#c6 BUG=166075, 246777 TEST=The Win Debug about:ipc dialog has the expected frame style and behavior. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204666

Patch Set 1 #

Patch Set 2 : Also call DialogDelegate::CreateDialogWidget for consistency. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	chrome/browser/ui/views/about_ipc_dialog.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/about_ipc_dialog.cc	View	1	3 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/16300008/3001

7 years, 6 months ago (2013-06-06 16:14:29 UTC) #3

Message was sent while issue was closed.

Change committed as 204666

Expand Messages | Collapse Messages