Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/browser/ui/views/about_ipc_dialog.cc

Issue 16300008: Revert the about:ipc dialog to the old style. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Also call DialogDelegate::CreateDialogWidget for consistency. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/about_ipc_dialog.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/about_ipc_dialog.cc
diff --git a/chrome/browser/ui/views/about_ipc_dialog.cc b/chrome/browser/ui/views/about_ipc_dialog.cc
index f9121dbdf4f435eab5e076366b421311eebb4fa4..3b9b4b6d7fd72fd4eb2fa2fd64d48f90aa81659d 100644
--- a/chrome/browser/ui/views/about_ipc_dialog.cc
+++ b/chrome/browser/ui/views/about_ipc_dialog.cc
@@ -60,7 +60,7 @@ enum {
// The singleton dialog box. This is non-NULL when a dialog is active so we
// know not to create a new one.
-AboutIPCDialog* g_active_dialog = NULL;
+AboutIPCDialog* g_dialog = NULL;
std::set<int> disabled_messages;
@@ -200,15 +200,15 @@ AboutIPCDialog::AboutIPCDialog()
}
AboutIPCDialog::~AboutIPCDialog() {
- g_active_dialog = NULL;
+ g_dialog = NULL;
IPC::Logging::GetInstance()->SetConsumer(NULL);
}
// static
void AboutIPCDialog::RunDialog() {
- if (!g_active_dialog) {
- g_active_dialog = new AboutIPCDialog;
- views::Widget::CreateWindow(g_active_dialog)->Show();
+ if (!g_dialog) {
+ g_dialog = new AboutIPCDialog;
+ views::DialogDelegate::CreateDialogWidget(g_dialog, NULL, NULL)->Show();
} else {
// TODO(brettw) it would be nice to focus the existing window.
}
@@ -335,6 +335,10 @@ bool AboutIPCDialog::CanResize() const {
return true;
}
+bool AboutIPCDialog::UseNewStyleForThisDialog() const {
+ return false;
+}
+
void AboutIPCDialog::ButtonPressed(
views::Button* button, const ui::Event& event) {
if (button == track_toggle_) {
« no previous file with comments | « chrome/browser/ui/views/about_ipc_dialog.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698