Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 16295020: Fix leak in pnacl translation cache and remove check suppressions (Closed)

Created:
7 years, 6 months ago by Derek Schuff
Modified:
7 years, 6 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Fix leak in pnacl translation cache and remove check suppressions R=jvoung@chromium.org BUG= https://code.google.com/p/chromium/issues/detail?id=246092 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3372 TEST= unit_tests --gtest_filter=PNaClTranslationCacheTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203929

Patch Set 1 #

Patch Set 2 : remove debug printf #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -59 lines) Patch
M chrome/browser/nacl_host/pnacl_translation_cache.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc View 3 chunks +12 lines, -1 line 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -37 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 2 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Derek Schuff
7 years, 6 months ago (2013-06-03 20:51:04 UTC) #1
jvoung (off chromium)
lgtm
7 years, 6 months ago (2013-06-03 21:24:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/16295020/6001
7 years, 6 months ago (2013-06-03 21:28:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/16295020/6001
7 years, 6 months ago (2013-06-04 04:53:02 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 11:20:31 UTC) #5
Message was sent while issue was closed.
Change committed as 203929

Powered by Google App Engine
This is Rietveld 408576698