chrome/browser/nacl_host/pnacl_translation_cache.cc - Issue 16295020: Fix leak in pnacl translation cache and remove check suppressions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/pnacl_translation_cache.cc

Issue 16295020: Fix leak in pnacl translation cache and remove check suppressions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/nacl_host/pnacl_translation_cache.cc

diff --git a/chrome/browser/nacl_host/pnacl_translation_cache.cc b/chrome/browser/nacl_host/pnacl_translation_cache.cc

index 4d8120915d2f287aa4b93d82b7867a8d9854278d..8316ba7052137881205682015efe67f1ba7f657e 100644

--- a/chrome/browser/nacl_host/pnacl_translation_cache.cc

+++ b/chrome/browser/nacl_host/pnacl_translation_cache.cc

@@ -224,7 +224,9 @@ void PNaClTranslationCache::WriteComplete(

PNaClTranslationCache::PNaClTranslationCache()

: disk_cache_(NULL), in_memory_(false) {}

-PNaClTranslationCache::~PNaClTranslationCache() {}

+PNaClTranslationCache::~PNaClTranslationCache() {

+ delete disk_cache_;

int PNaClTranslationCache::InitWithDiskBackend(

const base::FilePath& cache_dir,

« no previous file with comments | « no previous file | chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc » ('j') | no next file with comments »