Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16281006: Use a direct include of strings headers in chrome/renderer/. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, ahutter, mad+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, extensions-reviews_chromium.org, melevin+watch_chromium.org, benquan, dbeam+watch-autofill_chromium.org, dominich, rouslan+autofillwatch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, rpetterson, dyu1, rouslan+spellwatch_chromium.org, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, Raman Kakilate, Jered, donnd+watch_chromium.org, David Black, Dane Wallinga, samarth+watch_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Use a direct include of strings headers in chrome/renderer/. BUG=247723 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205581

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/console.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/logging_native_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/media_galleries_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/module_system.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/resource_request_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/mock_printer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/mock_printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/features_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/security_filter_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/custom_dictionary_engine.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/hunspell_engine.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_language.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spelling_engine.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/translate/translate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/web_apps.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/web_apps.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16281006/1
7 years, 6 months ago (2013-06-10 19:52:13 UTC) #1
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-11 06:44:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16281006/32001
7 years, 6 months ago (2013-06-11 14:51:57 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-11 17:45:13 UTC) #4
Message was sent while issue was closed. 
Change committed as 205581

Powered by Google App Engine
This is Rietveld 408576698