Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/renderer/extensions/logging_native_handler.cc

Issue 16281006: Use a direct include of strings headers in chrome/renderer/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/logging_native_handler.h" 5 #include "chrome/renderer/extensions/logging_native_handler.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 9
10 namespace extensions { 10 namespace extensions {
11 11
12 LoggingNativeHandler::LoggingNativeHandler(ChromeV8Context* context) 12 LoggingNativeHandler::LoggingNativeHandler(ChromeV8Context* context)
13 : ObjectBackedNativeHandler(context) { 13 : ObjectBackedNativeHandler(context) {
14 RouteFunction("DCHECK", 14 RouteFunction("DCHECK",
15 base::Bind(&LoggingNativeHandler::Dcheck, base::Unretained(this))); 15 base::Bind(&LoggingNativeHandler::Dcheck, base::Unretained(this)));
16 RouteFunction("CHECK", 16 RouteFunction("CHECK",
17 base::Bind(&LoggingNativeHandler::Check, base::Unretained(this))); 17 base::Bind(&LoggingNativeHandler::Check, base::Unretained(this)));
18 RouteFunction("DCHECK_IS_ON", 18 RouteFunction("DCHECK_IS_ON",
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 const v8::Handle<v8::String>& v8_string, 91 const v8::Handle<v8::String>& v8_string,
92 const std::string& dflt) { 92 const std::string& dflt) {
93 if (v8_string.IsEmpty()) 93 if (v8_string.IsEmpty())
94 return dflt; 94 return dflt;
95 std::string ascii_value = *v8::String::AsciiValue(v8_string); 95 std::string ascii_value = *v8::String::AsciiValue(v8_string);
96 return ascii_value.empty() ? dflt : ascii_value; 96 return ascii_value.empty() ? dflt : ascii_value;
97 } 97 }
98 98
99 } // namespace extensions 99 } // namespace extensions
100 100
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/extension_custom_bindings.cc ('k') | chrome/renderer/extensions/media_galleries_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698