Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 16280004: Use full path to apk install script and CheckInstall apk. (Closed)

Created:
7 years, 6 months ago by navabi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use full path to apk install script and CheckInstall apk. Allows device status check to be run from any directory after envsetup.sh has been run. Also fix for declaring fail_step_lst when there are no online devices. TBR=cmp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204208

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use pylib.constants.CHROME_DIR instead of env var. #

Patch Set 3 : Rebased. #

Patch Set 4 : Do not send alert on slow install and fail on low battery. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M build/android/device_status_check.py View 1 2 3 4 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
navabi
7 years, 6 months ago (2013-06-04 23:44:50 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-06-04 23:45:33 UTC) #2
Siva Chandra
lgtm One comment. https://codereview.chromium.org/16280004/diff/1/build/android/device_status_check.py File build/android/device_status_check.py (right): https://codereview.chromium.org/16280004/diff/1/build/android/device_status_check.py#newcode42 build/android/device_status_check.py:42: chrome_src = os.environ.get('CHROME_SRC') how about pylib.constants.CHROME_DIR?
7 years, 6 months ago (2013-06-04 23:51:03 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 6 months ago (2013-06-05 00:11:30 UTC) #4
boliu
committer stamp lgtm? Looks fine anyway
7 years, 6 months ago (2013-06-05 00:15:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/16280004/9001
7 years, 6 months ago (2013-06-05 00:17:05 UTC) #6
Isaac (away)
also lgtm
7 years, 6 months ago (2013-06-05 00:29:01 UTC) #7
commit-bot: I haz the power
7 years, 6 months ago (2013-06-05 08:22:47 UTC) #8
Message was sent while issue was closed.
Change committed as 204208

Powered by Google App Engine
This is Rietveld 408576698