Use full path to apk install script and CheckInstall apk.

build/android/device_status_check.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A class to keep track of devices across builds and report state."""
 import logging
 import optparse
 import os
 import smtplib
 import sys
 import re
 
+from pylib import android_commands
 from pylib import buildbot_report
-from pylib import android_commands
+from pylib import constants
 from pylib.cmd_helper import GetCmdOutput
 
 
 def DeviceInfo(serial):
   """Gathers info on a device via various adb calls.
 
   Args:
     serial: The serial of the attached device to construct info about.
 
   Returns:
     Tuple of device type, build id, report as a string, error messages, and
     boolean indicating whether or not device can be used for testing.
   """
 
   def AdbShellCmd(cmd):
     return GetCmdOutput('adb -s %s shell %s' % (serial, cmd),
                         shell=True).strip()
 
   device_type = AdbShellCmd('getprop ro.build.product')
   device_build = AdbShellCmd('getprop ro.build.id')
   device_product_name = AdbShellCmd('getprop ro.product.name')
 
   setup_wizard_disabled = AdbShellCmd(
       'getprop ro.setupwizard.mode') == 'DISABLED'
   battery = AdbShellCmd('dumpsys battery')
-  install_output = GetCmdOutput(['build/android/adb_install_apk.py', '--apk',
-                                 'build/android/CheckInstallApk-debug.apk'])
+  install_output = GetCmdOutput(
+    ['%s/build/android/adb_install_apk.py' % constants.CHROME_DIR, '--apk',
+     '%s/build/android/CheckInstallApk-debug.apk' % constants.CHROME_DIR])
   install_speed_found = re.findall('(\d+) KB/s', install_output)
   if install_speed_found:
     install_speed = int(install_speed_found[0])
   else:
     install_speed = 'Unknown'
   if 'Error' in battery:
     ac_power = 'Unknown'
     battery_level = 'Unknown'
     battery_temp = 'Unknown'
   else:
     ac_power = re.findall('AC powered: (\w+)', battery)[0]
     battery_level = int(re.findall('level: (\d+)', battery)[0])
     battery_temp = float(re.findall('temperature: (\d+)', battery)[0]) / 10
   report = ['Device %s (%s)' % (serial, device_type),
             '  Build: %s (%s)' % (device_build,
                                   AdbShellCmd('getprop ro.build.fingerprint')),
             '  Battery: %s%%' % battery_level,
             '  Battery temp: %s' % battery_temp,
             '  IMEI slice: %s' % AdbShellCmd('dumpsys iphonesubinfo '
                                              '| grep Device'
                                              "| awk '{print $4}'")[-6:],
             '  Wifi IP: %s' % AdbShellCmd('getprop dhcp.wlan0.ipaddress'),
             '  Install Speed: %s KB/s' % install_speed,
             '']
 
   errors = []
-  if battery_level < 5:
+  if battery_level < 15:
     errors += ['Device critically low in battery. Do not use for testing.']
   if not setup_wizard_disabled:
     errors += ['Setup wizard not disabled. Was it provisioned correctly?']
   if device_product_name == 'mantaray' and ac_power != 'true':
     errors += ['Mantaray device not connected to AC power.']
-  if install_speed < 800:
-    errors += ['Device install speed too low. Do not use for testing.']
+  # TODO(navabi): Insert warning once we have a better handle of what install
+  # speeds to expect. The following lines were causing too many alerts.
+  # if install_speed < 500:
+  #   errors += ['Device install speed too low. Do not use for testing.']
 
   # TODO(navabi): Determine if device status check step should fail on slow
   # install speed. The original CL caused the step to fail but was reverted
   # because it caused too many early failures. Determine if it was just flake.
   # Also, do not fail on 'Unknown' caused by offline device, because other
   # devices can still be used for tests.
-  fail_step = (battery_level == 'Unknown' or battery_level >= 5)
+  fail_step = (battery_level == 'Unknown' or battery_level >= 15)
   return device_type, device_build, '\n'.join(report), errors, fail_step
 
 
 def CheckForMissingDevices(options, adb_online_devs):
   """Uses file of previous online devices to detect broken phones.
 
   Args:
     options: out_dir parameter of options argument is used as the base
              directory to load and update the cache file.
     adb_online_devs: A list of serial numbers of the currently visible
@@ skipping 81 matching lines @@
   parser.add_option('', '--out-dir',
                     help='Directory where the device path is stored',
                     default=os.path.join(os.path.dirname(__file__), '..',
                                          '..', 'out'))
 
   options, args = parser.parse_args()
   if args:
     parser.error('Unknown options %s' % args)
   devices = android_commands.GetAttachedDevices()
   types, builds, reports, errors = [], [], [], []
+  fail_step_lst = []
   if devices:
     types, builds, reports, errors, fail_step_lst = zip(*[DeviceInfo(dev)
                                                           for dev in devices])
 
   err_msg = CheckForMissingDevices(options, devices) or []
 
   unique_types = list(set(types))
   unique_builds = list(set(builds))
 
   buildbot_report.PrintMsg('Online devices: %d. Device types %s, builds %s'
@@ skipping 16 matching lines @@
     # devices with critically low battery or install speed. Remove those devices
     # from testing, allowing build to continue with good devices.
     return 1
 
   if not devices:
     return 1
 
 
 if __name__ == '__main__':
   sys.exit(main())