[Android] Raise a compile time error if style resource is under values/

[Android] Raise a compile time error if style resource is under values/

Using paddingStart in style resource under values/ will cause crashes
on certain devices (crbug.com/243794). So Raise an error at compile time
if style resource exists under values/.

BUG=243952
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203229

[Ted C, 2013-05-30 18:00:38]

lgtm

[commit-bot: I haz the power, 2013-05-30 18:01:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/16238002/1

[newt (away), 2013-05-30 18:10:02]

lgtm
On May 30, 2013 10:49 AM, <kkimlabs@chromium.org> wrote:

> Reviewers: newt, Ted C,
>
> Description:
> [Android] Raise a compile time error if style resource is under values/
>
> Using paddingStart in style resource under values/ will cause crashes
> on certain devices (crbug.com/243794). So Raise an error at compile time
> if style resource exists under values/.
>
> BUG=243952
>
> Please review this at
https://codereview.chromium.**org/16238002/<https://codereview.chromium.org/1...
>
> SVN Base:
https://chromium.googlesource.**com/chromium/src.git@master<https://chromium....
>
> Affected files:
>   M build/android/gyp/generate_**v14_compatible_resources.py
>
>
> Index: build/android/gyp/generate_**v14_compatible_resources.py
> diff --git a/build/android/gyp/generate_**v14_compatible_resources.py
> b/build/android/gyp/generate_**v14_compatible_resources.py
> index 9e812158456a2fdafb082298083e1c**032490ef91..**
> cee06504b814ff74a6cdb5956d8867**94bd87eaf2 100755
> --- a/build/android/gyp/generate_**v14_compatible_resources.py
> +++ b/build/android/gyp/generate_**v14_compatible_resources.py
> @@ -267,10 +267,7 @@ def main(argv):
>                                                 output_qualifiers))
>          GenerateV14StyleResourcesInDir**(input_dir, output_v14_dir)
>        else:
> -        # TODO(kkimlabs): uncomment the below line and remove 'pass' once
> the
> -        # downstream fix
(https://gerrit-int.chromium.**org/#/c/38786/<https://gerrit-int.chromium.org/...)
> is landed.
> -        # ErrorIfStyleResourceExistsInDi**r(input_dir)
> -        pass
> +        ErrorIfStyleResourceExistsInDi**r(input_dir)
>
>    if options.stamp:
>      build_utils.Touch(options.**stamp)
>
>
>

[commit-bot: I haz the power, 2013-05-30 21:39:03]

Change committed as 203229