Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: build/android/gyp/generate_v14_compatible_resources.py

Issue 16238002: [Android] Raise a compile time error if style resource is under values/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/generate_v14_compatible_resources.py
diff --git a/build/android/gyp/generate_v14_compatible_resources.py b/build/android/gyp/generate_v14_compatible_resources.py
index 9e812158456a2fdafb082298083e1c032490ef91..cee06504b814ff74a6cdb5956d886794bd87eaf2 100755
--- a/build/android/gyp/generate_v14_compatible_resources.py
+++ b/build/android/gyp/generate_v14_compatible_resources.py
@@ -267,10 +267,7 @@ def main(argv):
output_qualifiers))
GenerateV14StyleResourcesInDir(input_dir, output_v14_dir)
else:
- # TODO(kkimlabs): uncomment the below line and remove 'pass' once the
- # downstream fix (https://gerrit-int.chromium.org/#/c/38786/) is landed.
- # ErrorIfStyleResourceExistsInDir(input_dir)
- pass
+ ErrorIfStyleResourceExistsInDir(input_dir)
if options.stamp:
build_utils.Touch(options.stamp)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698