Issue 16232014: Revert 203261 "split webkit/glue/webpreferences to common and re..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16232014: Revert 203261 "split webkit/glue/webpreferences to common and re..." (Closed)

Created:
7 years, 6 months ago by Ilya Sherman

Modified:
7 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 203261 "split webkit/glue/webpreferences to common and re..." Broke compile > split webkit/glue/webpreferences to common and renderer > > TBR=jamesr@chromium.org > > BUG=239107 > > Review URL: https://codereview.chromium.org/16216007 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203264

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -756 lines)			Patch
M	trunk/src/android_webview/native/aw_settings.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	trunk/src/chrome/browser/extensions/extension_webkit_preferences.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/extensions/gpu_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/prefs/chrome_pref_service_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/printing/print_dialog_cloud.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/prefs/prefs_tab_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/task_manager/task_manager_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/renderer/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/renderer/plugins/plugin_placeholder.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/chrome/renderer/plugins/webview_plugin.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/chrome/renderer/printing/print_web_view_helper.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/content/browser/android/content_settings.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/gpu/gpu_data_manager_impl_private.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	trunk/src/content/browser/renderer_host/render_view_host_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/renderer_host/render_widget_host_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/renderer_host/test_render_view_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/public/common/common_param_traits_macros.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/renderer/render_view_browsertest_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/renderer/render_view_impl.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	trunk/src/content/renderer/render_view_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/content/shell/common/webkit_test_helpers.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/shell/renderer/webkit_test_runner.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/shell/shell_content_browser_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/shell/webkit_test_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/test/test_web_contents.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ppapi/shared_impl/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ppapi/shared_impl/ppapi_preferences.h	View	1 chunk	+1 line, -1 line	0 comments	Download
D	trunk/src/webkit/common/webpreferences.h	View	1 chunk	+0 lines, -181 lines	0 comments	Download
D	trunk/src/webkit/common/webpreferences.cc	View	1 chunk	+0 lines, -171 lines	0 comments	Download
M	trunk/src/webkit/glue/webkit_glue.gypi	View	4 chunks	+3 lines, -6 lines	0 comments	Download
A +	trunk/src/webkit/glue/webpreferences.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/webkit/glue/webpreferences.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	trunk/src/webkit/renderer/webpreferences_renderer.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	trunk/src/webkit/renderer/webpreferences_renderer.cc	View	1 chunk	+0 lines, -346 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r203264.

Expand Messages | Collapse Messages