Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 16200002: Remove unused methods in WebGraphicsContext3D: isGLES2Compliant() and getPlatformTextureId() (Closed)

Created:
7 years, 6 months ago by dshwang
Modified:
7 years, 6 months ago
CC:
chromium-reviews, jonathan.backer, Ian Vollick, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove unused methods in WebGraphicsContext3D: isGLES2Compliant() and getPlatformTextureId() BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203301

Patch Set 1 #

Patch Set 2 : Patch to try bot. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/compositor/test_web_graphics_context_3d.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/test_web_graphics_context_3d.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/common/gpu/webgraphicscontext3d_in_process_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
dshwang
7 years, 6 months ago (2013-05-29 17:42:51 UTC) #1
dshwang
Issue 14727008 (http://crrev.com/14727008) removed isGLES2Compliant() and getPlatformTextureId() in GraphicsContext3D. It is a follow-up patch. After ...
7 years, 6 months ago (2013-05-29 17:45:16 UTC) #2
dshwang
On 2013/05/29 17:45:16, dshwang wrote: > After this patch is landed, I will remove isGLES2Compliant() ...
7 years, 6 months ago (2013-05-29 17:48:05 UTC) #3
jamesr
lgtm
7 years, 6 months ago (2013-05-29 23:02:11 UTC) #4
dshwang
On 2013/05/29 23:02:11, jamesr wrote: > lgtm thx jamesr for review :) could some owners ...
7 years, 6 months ago (2013-05-30 06:13:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/16200002/1
7 years, 6 months ago (2013-05-30 12:35:03 UTC) #6
dshwang
7 years, 6 months ago (2013-05-30 12:38:14 UTC) #7
greggman
lgtm
7 years, 6 months ago (2013-05-30 16:04:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/16200002/10001
7 years, 6 months ago (2013-05-30 18:54:49 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=5938
7 years, 6 months ago (2013-05-30 19:13:32 UTC) #10
jamesr
Adding piman to review ui/compositor/
7 years, 6 months ago (2013-05-30 19:22:04 UTC) #11
piman
lgtm
7 years, 6 months ago (2013-05-30 19:26:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/16200002/10001
7 years, 6 months ago (2013-05-30 19:27:44 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-05-31 01:48:50 UTC) #14
Message was sent while issue was closed.
Change committed as 203301

Powered by Google App Engine
This is Rietveld 408576698