Source/core/html/HTMLSelectElement.cpp - Issue 16194013: Mouse press should focus on any types of form controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 16194013: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase, common->default, etc. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index 7d8288dc8b5892f37ffa805a17f95fc2f996a410..c11be6bb0308b00a106a7d5511caef8d0dec70b3 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -322,11 +322,9 @@ bool HTMLSelectElement::isKeyboardFocusable(KeyboardEvent* event) const

return HTMLFormControlElementWithState::isKeyboardFocusable(event);

}

-bool HTMLSelectElement::isMouseFocusable() const

+bool HTMLSelectElement::shouldShowFocusRingOnMouseFocus() const

{

- if (renderer())

- return isFocusable();

- return HTMLFormControlElementWithState::isMouseFocusable();

+ return true;

}

bool HTMLSelectElement::canSelectAll() const