Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: Source/core/html/HTMLSelectElement.cpp

Issue 16194013: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase, common->default, etc. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 HTMLFormControlElementWithState::parseAttribute(name, value); 315 HTMLFormControlElementWithState::parseAttribute(name, value);
316 } 316 }
317 317
318 bool HTMLSelectElement::isKeyboardFocusable(KeyboardEvent* event) const 318 bool HTMLSelectElement::isKeyboardFocusable(KeyboardEvent* event) const
319 { 319 {
320 if (renderer()) 320 if (renderer())
321 return isFocusable(); 321 return isFocusable();
322 return HTMLFormControlElementWithState::isKeyboardFocusable(event); 322 return HTMLFormControlElementWithState::isKeyboardFocusable(event);
323 } 323 }
324 324
325 bool HTMLSelectElement::isMouseFocusable() const 325 bool HTMLSelectElement::shouldShowFocusRingOnMouseFocus() const
326 { 326 {
327 if (renderer()) 327 return true;
328 return isFocusable();
329 return HTMLFormControlElementWithState::isMouseFocusable();
330 } 328 }
331 329
332 bool HTMLSelectElement::canSelectAll() const 330 bool HTMLSelectElement::canSelectAll() const
333 { 331 {
334 return !usesMenuList(); 332 return !usesMenuList();
335 } 333 }
336 334
337 RenderObject* HTMLSelectElement::createRenderer(RenderArena* arena, RenderStyle* ) 335 RenderObject* HTMLSelectElement::createRenderer(RenderArena* arena, RenderStyle* )
338 { 336 {
339 if (usesMenuList()) 337 if (usesMenuList())
(...skipping 1237 matching lines...) Expand 10 before | Expand all | Expand 10 after
1577 { 1575 {
1578 if (!value) { 1576 if (!value) {
1579 ec = TYPE_MISMATCH_ERR; 1577 ec = TYPE_MISMATCH_ERR;
1580 return false; 1578 return false;
1581 } 1579 }
1582 setOption(index, value.get(), ec); 1580 setOption(index, value.get(), ec);
1583 return true; 1581 return true;
1584 } 1582 }
1585 1583
1586 } // namespace 1584 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698