Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 16174013: Remove dependency of WebData on content (Closed)

Created:
7 years, 6 months ago by droger
Modified:
7 years, 6 months ago
Reviewers:
stuartmorgan, Jói, blundell
CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove dependency of WebData on content This CL uses MessageLoopProxy instead of BrowserThread. It also moves autofill test code that was in web_data_service_test_util.h to autofill/. BUG=248049 TBR=joth, stuartmorgan, piman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206726

Patch Set 1 #

Patch Set 2 : Remove dependency on content #

Patch Set 3 : Fix compile and rename a class #

Patch Set 4 : Fix a few more compilation errors #

Patch Set 5 : Revert a minor change #

Patch Set 6 : switch to Curiously Recurring Template Pattern #

Patch Set 7 : rebase #

Total comments: 2

Patch Set 8 : Fix android compilation #

Total comments: 2

Patch Set 9 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -102 lines) Patch
M android_webview/browser/aw_form_database_service.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/oauth_login_manager.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/webdata/token_web_data.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_data_service.cc View 1 4 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/browser/webdata/autofill_webdata.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M components/autofill/browser/webdata/autofill_webdata_backend_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/browser/webdata/autofill_webdata_service.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M components/autofill/browser/webdata/web_data_service_unittest.cc View 1 2 3 4 5 6 4 chunks +39 lines, -3 lines 0 comments Download
M components/webdata/DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
M components/webdata/common/web_data_request_manager.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/webdata/common/web_data_service_backend.h View 1 2 3 4 5 4 chunks +8 lines, -15 lines 0 comments Download
M components/webdata/common/web_data_service_backend.cc View 1 2 3 4 5 6 1 chunk +5 lines, -4 lines 0 comments Download
M components/webdata/common/web_data_service_base.h View 1 2 3 4 5 6 7 8 4 chunks +10 lines, -12 lines 0 comments Download
M components/webdata/common/web_data_service_base.cc View 1 2 3 4 5 2 chunks +6 lines, -11 lines 0 comments Download
M components/webdata/common/web_data_service_test_util.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
M components/webdata/common/web_database_service.h View 1 2 3 4 5 6 2 chunks +5 lines, -1 line 0 comments Download
M components/webdata/common/web_database_service.cc View 1 2 3 4 5 6 9 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
droger
blundell: could you do a first pass on this?
7 years, 6 months ago (2013-06-13 11:00:42 UTC) #1
droger
This is ready for review.
7 years, 6 months ago (2013-06-17 09:09:53 UTC) #2
Jói
I think you added me (maybe others?) as a reviewer, so I'll get started. It's ...
7 years, 6 months ago (2013-06-17 09:18:12 UTC) #3
Jói
LGTM, nice.
7 years, 6 months ago (2013-06-17 09:22:13 UTC) #4
droger
On 2013/06/17 09:18:12, Jói wrote: > I think you added me (maybe others?) as a ...
7 years, 6 months ago (2013-06-17 10:48:53 UTC) #5
blundell
https://codereview.chromium.org/16174013/diff/42001/components/webdata/common/web_data_service_base.cc File components/webdata/common/web_data_service_base.cc (left): https://codereview.chromium.org/16174013/diff/42001/components/webdata/common/web_data_service_base.cc#oldcode30 components/webdata/common/web_data_service_base.cc:30: // WebDataService requires DB thread if instantiated. Did this ...
7 years, 6 months ago (2013-06-17 10:50:32 UTC) #6
droger
https://codereview.chromium.org/16174013/diff/42001/components/webdata/common/web_data_service_base.cc File components/webdata/common/web_data_service_base.cc (left): https://codereview.chromium.org/16174013/diff/42001/components/webdata/common/web_data_service_base.cc#oldcode30 components/webdata/common/web_data_service_base.cc:30: // WebDataService requires DB thread if instantiated. On 2013/06/17 ...
7 years, 6 months ago (2013-06-17 11:10:51 UTC) #7
blundell
lgtm
7 years, 6 months ago (2013-06-17 11:16:33 UTC) #8
droger
TBR OWNERS: joth for android_webview/browser/aw_form_database_service.cc piman for chrome/browser/chromeos/login/oauth_login_manager.cc stuartmorgan for chrome/browser/password_manager/password_store_win_unittest.cc
7 years, 6 months ago (2013-06-17 11:34:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/16174013/71002
7 years, 6 months ago (2013-06-17 11:34:20 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=164169
7 years, 6 months ago (2013-06-17 13:03:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/16174013/71002
7 years, 6 months ago (2013-06-17 13:06:58 UTC) #12
commit-bot: I haz the power
Change committed as 206726
7 years, 6 months ago (2013-06-17 15:33:38 UTC) #13
stuartmorgan
7 years, 6 months ago (2013-06-18 08:00:37 UTC) #14
Message was sent while issue was closed.
password_manager LGTM

Powered by Google App Engine
This is Rietveld 408576698