Remove dependency of WebData on content

Remove dependency of WebData on content

This CL uses MessageLoopProxy instead of BrowserThread. It also moves autofill
test code that was in web_data_service_test_util.h to autofill/.

BUG=248049
TBR=joth, stuartmorgan, piman

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206726

[droger, 2013-06-13 11:00:42]

blundell: could you do a first pass on this?

[droger, 2013-06-17 09:09:53]

This is ready for review.

[Jói, 2013-06-17 09:18:12]

I think you added me (maybe others?) as a reviewer, so I'll get
started.  It's usually better to specify explicitly (in your message)
who you added as reviewer, and for which parts.

Also, I think you may have added me via the wrong (non-@chromium.org)
address.  I've corrected that.

Cheers,
Jói


On Mon, Jun 17, 2013 at 9:09 AM,  <droger@chromium.org> wrote:
> This is ready for review.
>
> https://codereview.chromium.org/16174013/

[Jói, 2013-06-17 09:22:13]

LGTM, nice.

[droger, 2013-06-17 10:48:53]

On 2013/06/17 09:18:12, Jói wrote:
> I think you added me (maybe others?) as a reviewer, so I'll get
> started.  It's usually better to specify explicitly (in your message)
> who you added as reviewer, and for which parts.
> 
> Also, I think you may have added me via the wrong (mailto:non-@chromium.org)
> address.  I've corrected that.

I'm sorry. Thanks for fixing this, and thanks for the review.

[blundell, 2013-06-17 10:50:32]

https://codereview.chromium.org/16174013/diff/42001/components/webdata/common...
File components/webdata/common/web_data_service_base.cc (left):

https://codereview.chromium.org/16174013/diff/42001/components/webdata/common...
components/webdata/common/web_data_service_base.cc:30: // WebDataService
requires DB thread if instantiated.
Did this just get dropped?

https://codereview.chromium.org/16174013/diff/65001/components/webdata/common...
File components/webdata/common/web_data_service_base.h (right):

https://codereview.chromium.org/16174013/diff/65001/components/webdata/common...
components/webdata/common/web_data_service_base.h:24: // Base for WebDataService
class hierarchy.
Add a comment saying that this class should be destroyed on the UI thread.

[droger, 2013-06-17 11:10:51]

https://codereview.chromium.org/16174013/diff/42001/components/webdata/common...
File components/webdata/common/web_data_service_base.cc (left):

https://codereview.chromium.org/16174013/diff/42001/components/webdata/common...
components/webdata/common/web_data_service_base.cc:30: // WebDataService
requires DB thread if instantiated.
On 2013/06/17 10:50:33, blundell wrote:
> Did this just get dropped?

Yes, I removed that check.
This class does not use the DB thread, and there are already checks in the other
classes where the DB thread is actually used, so I think this one is not needed.

https://codereview.chromium.org/16174013/diff/65001/components/webdata/common...
File components/webdata/common/web_data_service_base.h (right):

https://codereview.chromium.org/16174013/diff/65001/components/webdata/common...
components/webdata/common/web_data_service_base.h:24: // Base for WebDataService
class hierarchy.
On 2013/06/17 10:50:33, blundell wrote:
> Add a comment saying that this class should be destroyed on the UI thread.

Done.

[blundell, 2013-06-17 11:16:33]

lgtm

[droger, 2013-06-17 11:34:00]

TBR OWNERS:
joth for android_webview/browser/aw_form_database_service.cc
piman for chrome/browser/chromeos/login/oauth_login_manager.cc
stuartmorgan for chrome/browser/password_manager/password_store_win_unittest.cc

[commit-bot: I haz the power, 2013-06-17 11:34:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/16174013/71002

[commit-bot: I haz the power, 2013-06-17 13:03:51]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-06-17 13:06:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/droger@chromium.org/16174013/71002

[commit-bot: I haz the power, 2013-06-17 15:33:38]

Change committed as 206726

[stuartmorgan, 2013-06-18 08:00:37]

password_manager LGTM