Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3051)

Unified Diff: chrome/browser/signin/signin_tracker.cc

Issue 16173006: No longer trigger signin errors on connection_failed for sync. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/signin/signin_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_tracker.cc
diff --git a/chrome/browser/signin/signin_tracker.cc b/chrome/browser/signin/signin_tracker.cc
index cdddc4966590e381a1aeffda7c2072334b4b6b94..cb3312057e4d61f09b545dde33e94bde039b8ca5 100644
--- a/chrome/browser/signin/signin_tracker.cc
+++ b/chrome/browser/signin/signin_tracker.cc
@@ -171,9 +171,14 @@ bool SigninTracker::AreServicesSignedIn(Profile* profile) {
return true;
ProfileSyncService* service =
ProfileSyncServiceFactory::GetForProfile(profile);
+ // Check the sync service state - we ignore CONNECTION_FAILED errors here
+ // because they are transient and do not signify a failure of the signin
+ // process.
return (service->IsSyncEnabledAndLoggedIn() &&
service->IsSyncTokenAvailable() &&
- service->GetAuthError().state() == GoogleServiceAuthError::NONE &&
+ (service->GetAuthError().state() == GoogleServiceAuthError::NONE ||
+ service->GetAuthError().state() ==
+ GoogleServiceAuthError::CONNECTION_FAILED) &&
!service->HasUnrecoverableError());
}
« no previous file with comments | « no previous file | chrome/browser/signin/signin_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698