No longer trigger signin errors on connection_failed for sync.

chrome/browser/signin/signin_tracker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/signin_tracker.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/signin/signin_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/token_service.h"
@@ skipping 153 matching lines @@
 
 // static
 bool SigninTracker::AreServicesSignedIn(Profile* profile) {
   if (!AreServiceTokensLoaded(profile))
     return false;
   // Don't care about the sync state if sync is disabled by policy.
   if (!profile->IsSyncAccessible())
     return true;
   ProfileSyncService* service =
       ProfileSyncServiceFactory::GetForProfile(profile);
+  // Check the sync service state - we ignore CONNECTION_FAILED errors here
+  // because they are transient and do not signify a failure of the signin
+  // process.
   return (service->IsSyncEnabledAndLoggedIn() &&
           service->IsSyncTokenAvailable() &&
-          service->GetAuthError().state() == GoogleServiceAuthError::NONE &&
+          (service->GetAuthError().state() == GoogleServiceAuthError::NONE ||
+           service->GetAuthError().state() ==
+               GoogleServiceAuthError::CONNECTION_FAILED) &&
           !service->HasUnrecoverableError());
 }
 
 // static
 SigninTracker::LoginState SigninTracker::GetSigninState(
     Profile* profile,
     GoogleServiceAuthError* error) {
   SigninManagerBase* signin = SigninManagerFactory::GetForProfile(profile);
   if (signin->GetAuthenticatedUsername().empty()) {
     // User is signed out, trigger a signin failure.
@@ skipping 25 matching lines @@
     if (error)
       *error = signin->signin_global_error()->GetLastAuthError();
     return WAITING_FOR_GAIA_VALIDATION;
   }
 
   if (!service || service->sync_initialized())
     return SIGNIN_COMPLETE;
 
   return SERVICES_INITIALIZING;
 }