Issue 16173006: No longer trigger signin errors on connection_failed for sync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16173006: No longer trigger signin errors on connection_failed for sync. (Closed)

Created:
7 years, 6 months ago by Andrew T Wilson (Slow)

Modified:
7 years, 6 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

No longer trigger signin errors on connection_failed for sync. If ProfileSyncService gets a transient network error trying to contact the backend, we no longer treat this as a fatal signin error. Also, we no longer display a "wait for the backend to startup" spinner in cases where we know the spinner will immediately be dismissed, to avoid a gnarly infinite loop in the UI code. BUG=244769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203968

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -3 lines)			Patch
M	chrome/browser/signin/signin_tracker.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/signin/signin_tracker_unittest.cc	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

On 2013/05/31 12:13:46, Andrew T Wilson wrote: > PTAL Ping!

7 years, 6 months ago (2013-06-03 08:01:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/16173006/1

7 years, 6 months ago (2013-06-04 06:48:15 UTC) #4

Message was sent while issue was closed.

Change committed as 203968

Expand Messages | Collapse Messages