Clean up async app launcher enabled checks.

Clean up async app launcher enabled checks.

The app launcher enable state no longer requires a registry check so
we can remove all of the asynchronous apis that were in place for it.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203921

[koz (OOO until 15th September), 2013-05-30 04:08:39]

https://codereview.chromium.org/16172005/diff/10/apps/app_launcher.cc
File apps/app_launcher.cc (right):

https://codereview.chromium.org/16172005/diff/10/apps/app_launcher.cc#newcode33
apps/app_launcher.cc:33: NOTREACHED();
The comment here seems to imply this will crash some tests. return false
instead?

https://codereview.chromium.org/16172005/diff/10/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
(left):

https://codereview.chromium.org/16172005/diff/10/chrome/browser/extensions/ap...
chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:520: void
CompleteInstallFunction::OnGetAppLauncherEnabled(
Remove function declaration.

https://codereview.chromium.org/16172005/diff/10/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm (left):

https://codereview.chromium.org/16172005/diff/10/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm:111: void
BookmarkBarBridge::OnAppLauncherEnabledCompleted(
The declaration of this function can be removed now.

https://codereview.chromium.org/16172005/diff/10/chrome/browser/ui/views/book...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (left):

https://codereview.chromium.org/16172005/diff/10/chrome/browser/ui/views/book...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:1878: void
BookmarkBarView::OnAppLauncherEnabledCompleted(bool app_launcher_enabled) {
Remove function declaration

[calamity, 2013-05-31 01:15:22]

+sky for OWNERS

Could you please review chrome/browser/ui/.

Thanks.

https://chromiumcodereview.appspot.com/16172005/diff/10/apps/app_launcher.cc
File apps/app_launcher.cc (right):

https://chromiumcodereview.appspot.com/16172005/diff/10/apps/app_launcher.cc#...
apps/app_launcher.cc:33: NOTREACHED();
On 2013/05/30 04:08:40, koz wrote:
> The comment here seems to imply this will crash some tests. return false
> instead?

Done.

https://chromiumcodereview.appspot.com/16172005/diff/10/chrome/browser/extens...
File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
(left):

https://chromiumcodereview.appspot.com/16172005/diff/10/chrome/browser/extens...
chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:520: void
CompleteInstallFunction::OnGetAppLauncherEnabled(
On 2013/05/30 04:08:40, koz wrote:
> Remove function declaration.

Done.

https://chromiumcodereview.appspot.com/16172005/diff/10/chrome/browser/ui/coc...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm (left):

https://chromiumcodereview.appspot.com/16172005/diff/10/chrome/browser/ui/coc...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_bridge.mm:111: void
BookmarkBarBridge::OnAppLauncherEnabledCompleted(
On 2013/05/30 04:08:40, koz wrote:
> The declaration of this function can be removed now.

Done.

https://chromiumcodereview.appspot.com/16172005/diff/10/chrome/browser/ui/vie...
File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (left):

https://chromiumcodereview.appspot.com/16172005/diff/10/chrome/browser/ui/vie...
chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:1878: void
BookmarkBarView::OnAppLauncherEnabledCompleted(bool app_launcher_enabled) {
On 2013/05/30 04:08:40, koz wrote:
> Remove function declaration

Done.

[koz (OOO until 15th September), 2013-05-31 02:46:20]

lgtm

https://codereview.chromium.org/16172005/diff/6001/apps/app_launcher.cc
File apps/app_launcher.cc (right):

https://codereview.chromium.org/16172005/diff/6001/apps/app_launcher.cc#newco...
apps/app_launcher.cc:31: // In some tests, the prefs aren't initialised.
nit: outdent by two

[calamity, 2013-06-03 07:32:09]

+sky for OWNERS

Could you please review chrome/browser/ui?

Thanks.

[sky, 2013-06-03 15:58:07]

LGTM

[commit-bot: I haz the power, 2013-06-03 17:00:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/16172005/15001

[commit-bot: I haz the power, 2013-06-03 17:23:47]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-04 01:13:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/16172005/31001

[commit-bot: I haz the power, 2013-06-04 11:00:31]

Change committed as 203921