Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2095)

Unified Diff: apps/app_launcher.h

Issue 16172005: Clean up async app launcher enabled checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | apps/app_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/app_launcher.h
diff --git a/apps/app_launcher.h b/apps/app_launcher.h
index 0ccc1bfd5d6a981a34347994cdf3ebec68965910..07f6b6ea4680e8f14c840859cefad4f6b4ba4b0e 100644
--- a/apps/app_launcher.h
+++ b/apps/app_launcher.h
@@ -9,31 +9,8 @@
namespace apps {
-// Called on the UI thread after determining if the launcher is enabled. A
-// boolean flag is passed, which is true if the app launcher is enabled.
-typedef base::Callback<void(bool)> OnAppLauncherEnabledCompleted;
-
-// TODO(calamity): Remove all the "uncertain" apis because windows app launcher
-// enabled is now just a single pref that we can check synchronously and with
-// confidence. This includes changing GetIsAppLauncherEnabled to a synchronous
-// API.
-
-// A synchronous check to determine if the app launcher is enabled. If the
-// registry needs to be determined to find an accurate answer, this function
-// will NOT do so; instead if will default to false (the app launcher is not
-// enabled).
-// This function does not use the cached preference of whether the launcher
-// was enabled or not.
-bool MaybeIsAppLauncherEnabled();
-
-// Determine whether the app launcher is enabled or not. This may involve a trip
-// to a blocking thread. |completion_callback| is called when an answer is
-// ready. This needs to be called on the UI thread.
-void GetIsAppLauncherEnabled(
- const OnAppLauncherEnabledCompleted& completion_callback);
-
-// Returns whether the app launcher was enabled the last time it was checked.
-bool WasAppLauncherEnabled();
+// Returns whether the app launcher has been enabled.
+bool IsAppLauncherEnabled();
} // namespace apps
« no previous file with comments | « no previous file | apps/app_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698