Use a weak pointer to post service control events and session change notifications.

Use a weak pointer to post service control events and session change notifications.

BUG=241136
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204918

[alexeypa (please no reviews), 2013-06-07 17:32:01]

PTAL

[Wez, 2013-06-07 17:48:23]

lgtm

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/daemon_p...
File remoting/host/daemon_process.h (right):

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/daemon_p...
remoting/host/daemon_process.h:108: void Stop();
nit: Comment explaining Stop() semantics here, plz.

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/win/host...
File remoting/host/win/host_service.cc (right):

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/win/host...
remoting/host/win/host_service.cc:422: daemon_process_.reset(NULL);
nit: No need for explicit NULL.

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/win/host...
File remoting/host/win/host_service.h (right):

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/win/host...
remoting/host/win/host_service.h:113:
scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
nit: It's important that we're not clearing |main_task_runner_| before exiting
RunServiceImpl() etc, otherwise PostTasks from service notifications would barf;
might be worth calling that out in this comment.

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/win/host...
remoting/host/win/host_service.h:126: base::WeakPtr<HostService> weak_self_;
nit: Elsewhere we call this |weak_ptr_|.

[alexeypa (please no reviews), 2013-06-07 18:30:23]

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/daemon_p...
File remoting/host/daemon_process.h (right):

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/daemon_p...
remoting/host/daemon_process.h:108: void Stop();
On 2013/06/07 17:48:24, Wez wrote:
> nit: Comment explaining Stop() semantics here, plz.

Done.

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/win/host...
File remoting/host/win/host_service.cc (right):

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/win/host...
remoting/host/win/host_service.cc:422: daemon_process_.reset(NULL);
On 2013/06/07 17:48:24, Wez wrote:
> nit: No need for explicit NULL.

Done.

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/win/host...
File remoting/host/win/host_service.h (right):

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/win/host...
remoting/host/win/host_service.h:113:
scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
On 2013/06/07 17:48:24, Wez wrote:
> nit: It's important that we're not clearing |main_task_runner_| before exiting
> RunServiceImpl() etc, otherwise PostTasks from service notifications would
barf;
> might be worth calling that out in this comment.

Done.

https://chromiumcodereview.appspot.com/16143004/diff/1/remoting/host/win/host...
remoting/host/win/host_service.h:126: base::WeakPtr<HostService> weak_self_;
On 2013/06/07 17:48:24, Wez wrote:
> nit: Elsewhere we call this |weak_ptr_|.

Done.

[commit-bot: I haz the power, 2013-06-07 18:31:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/16143004/9002

[commit-bot: I haz the power, 2013-06-07 19:45:46]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-06-07 20:01:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/16143004/9002

[commit-bot: I haz the power, 2013-06-07 20:50:07]

Change committed as 204918