Issue 16122002: [NaCl SDK] MountNodeDir::GetDents sets d_off instead of leaving it undefined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16122002: [NaCl SDK] MountNodeDir::GetDents sets d_off instead of leaving it undefined. (Closed)

Created:
7 years, 6 months ago by Matt Giuca

Modified:
7 years, 6 months ago

Reviewers:
binji

CC:
chromium-reviews, binji, Sam Clegg, chrome-apps-syd-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[NaCl SDK] MountNodeDir::GetDents sets d_off instead of leaving it undefined. This fixes the response from readdir when applied to memfs mounts. Also added tests for st_ino (from MountNode::GetStat) and d_ino, d_off and d_reclen (from MountNodeDir::GetDents). In a test environment, MountNode now sets st_ino to 1, instead of 0 (since 0 is an invalid inode value). BUG=244315 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202767

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -0 lines)			Patch
M	native_client_sdk/src/libraries/nacl_io/mount_node.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io_test/mount_node_test.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/16122002/1

7 years, 6 months ago (2013-05-28 23:50:46 UTC) #3

Message was sent while issue was closed.

Change committed as 202767

Expand Messages | Collapse Messages