native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc - Issue 16122002: [NaCl SDK] MountNodeDir::GetDents sets d_off instead of leaving it undefined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc

Issue 16122002: [NaCl SDK] MountNodeDir::GetDents sets d_off instead of leaving it undefined. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/mount_node.cc ('k') | native_client_sdk/src/libraries/nacl_io_test/mount_node_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc b/native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc

index 541a70fbcd8f37e4a2c3df42531b5253ce2b59f4..7a33bfd684febb748d55304436c235fb1623a230 100644

--- a/native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc

+++ b/native_client_sdk/src/libraries/nacl_io/mount_node_dir.cc

@@ -129,6 +129,7 @@ void MountNodeDir::BuildCache() {

MountNode* node = it->second;

size_t len = it->first.length();

cache_[index].d_ino = node->stat_.st_ino;

+ cache_[index].d_off = sizeof(struct dirent);

cache_[index].d_reclen = sizeof(struct dirent);

cache_[index].d_name[len] = 0;

strncpy(cache_[index].d_name, &it->first[0], len);